This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Added resource pipe and service for libraries #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
requested a review
from Blackbaud-BobbyEarl
as a code owner
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 9 +4
Lines 99 146 +47
Branches 22 26 +4
=====================================
+ Hits 99 146 +47
Continue to review full report at Codecov.
|
This was referenced Oct 15, 2018
|
|
||
| private getStringForLocale( | ||
| info: SkyAppLocaleInfo, | ||
| name: string, ...args: any[] |
There was a problem hiding this comment.
Missing line break
| return this.getStringForLocale({ locale: 'en_US' }, name, args); | ||
| } | ||
|
|
||
| private getStringForLocale( |
There was a problem hiding this comment.
Remove getDefaultString and make this public.
| Observable | ||
| } from 'rxjs/Observable'; | ||
|
|
||
| import 'rxjs/add/observable/merge'; |
There was a problem hiding this comment.
Remove this.
Blackbaud-BobbyEarl
approved these changes
Oct 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulider PR: blackbaud/skyux-builder#486
Builder Plugin PR: blackbaud/skyux-sdk-builder-plugin-skyux#2
SKY UX Lookup PR (implementation demo): blackbaud/skyux-lookup#3