This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Added host locale provider #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 53 54 +1
Lines 1642 1653 +11
Branches 241 245 +4
=====================================
+ Hits 1642 1653 +11
Continue to review full report at Codecov.
|
…lder into host-locale-provider
| public static readonly defaultLocale = 'en-US'; | ||
|
|
||
| constructor( | ||
| private windowRef: SkyAppWindowRef |
There was a problem hiding this comment.
FYI: I had to remove SkyAppLocaleProvider from the constructor because Angular was barking about a circular injection. See: https://github.com/blackbaud/skyux-i18n/blob/master/src/app/public/modules/i18n/host-locale-provider.ts#L29
This was referenced Oct 16, 2018
Blackbaud-SteveBrush
requested review from
Blackbaud-PaulCrowder and
Blackbaud-BobbyEarl
Blackbaud-BobbyEarl
previously approved these changes
Oct 17, 2018
Blackbaud-SteveBrush
dismissed
Blackbaud-BobbyEarl’s stale review
via
4fa13bb
Blackbaud-BobbyEarl
approved these changes
Oct 17, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.