Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Disable aria allowed attr #465

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Disable aria allowed attr #465

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef898e1
disabled aria-allowed-attr
blackbaud-conorwright Sep 5, 2018
dfe44d7
added comment explaining disable
blackbaud-conorwright Sep 5, 2018
4ec2c15
added link to axe issue
blackbaud-conorwright Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/axe/axe.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ const defaults = {
'bypass': { 'enabled': true },
'tabindex': { 'enabled': true },

'aria-allowed-attr': { 'enabled': true },
// TEMP: this should be re-enabled when we upgrade to axe-core ^3.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually prefix comments like this with // TODO: so that they are easily searched for later on.

Also, could you:

  1. Put a link in the comment to the Stack Overflow (or similar) article describing the problem?
  2. Create an issue in Builder so that we don't forget to take care of this in version 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue made: blackbaud/skyux2#1964
Updated comment

'aria-allowed-attr': { 'enabled': false },
'aria-required-attr': { 'enabled': true },
'aria-required-children': { 'enabled': true },
'aria-required-parent': { 'enabled': true },
Expand Down