This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Disable aria allowed attr #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 71 71
Lines 1914 1914
Branches 305 305
=======================================
Hits 1903 1903
Misses 11 11
Continue to review full report at Codecov.
|
config/axe/axe.config.js
Outdated
| @@ -50,7 +50,8 @@ const defaults = { | |||
| 'bypass': { 'enabled': true }, | |||
| 'tabindex': { 'enabled': true }, | |||
|
|
|||
| 'aria-allowed-attr': { 'enabled': true }, | |||
| // TEMP: this should be re-enabled when we upgrade to axe-core ^3.1.1 | |||
There was a problem hiding this comment.
We usually prefix comments like this with // TODO: so that they are easily searched for later on.
Also, could you:
- Put a link in the comment to the Stack Overflow (or similar) article describing the problem?
- Create an issue in Builder so that we don't forget to take care of this in version 2.
There was a problem hiding this comment.
Issue made: blackbaud/skyux2#1964
Updated comment
|
Related issue: blackbaud/skyux2#1964 |
Blackbaud-BobbyEarl
approved these changes
Sep 5, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
* disabled aria-allowed-attr * added comment explaining disable * added link to axe issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remain disabled until we can upgrade to using axe-core 3.1.1. The current version does not recognize certain attributes as appropriate for certain roles that we use together and will cause failures to this rule.