This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Fixed deps + test #171
Merged
Fixed deps + test #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 38 38
Lines 845 845
Branches 113 113
=======================================
Hits 812 812
Misses 33 33
Continue to review full report at Codecov.
|
Blackbaud-PaulCrowder
suggested changes
Jun 6, 2017
runtime/auth-http.spec.ts
Outdated
| /** | ||
| * PLEASE NOTE | ||
| * If this tests fails, it means you've changed the required parameters to the constructor. | ||
| * To successfully maintain backwards compatibility, make any new parameters optional. |
There was a problem hiding this comment.
You might also want to specify that new parameters must also be added to the end of the constructor for the case where someone's calling the constructor by using useFactory():
providers: [
provide: SkyAuthHttp,
useFactory: (a, b, c) => {
return new SkyAuthHttp(a, b, SomethingElse);
},
deps: [a, b, c]
]
Blackbaud-SteveBrush
previously approved these changes
Jun 6, 2017
Blackbaud-SteveBrush
dismissed
their stale review
Looks like Paul has this one...
Blackbaud-PaulCrowder
approved these changes
Jun 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.