Fixed deps + test (#171)

* Fixed deps + test

* Added new test + note

* Updated test comment and package.json.  Added entry for CHANGELOG.md

Author: Bobby Earl

CHANGELOG.md

@@ -1,5 +1,9 @@
 # 1.0.0-beta.29 (2017-06-05)
 
+- Bugfix for `SkyAuthHttp`. [#171](https://github.com/blackbaud/skyux-builder/pull/171)
+
+# 1.0.0-beta.29 (2017-06-05)
+
 - Implemented style loader to resolve FOUC (flash of unstyled content). [#166](https://github.com/blackbaud/skyux-builder/pull/166)
 - Initial creation of `skyRouterLink` directive. [#159](https://github.com/blackbaud/skyux-builder/pull/159)
 - Updated testing suite to include internal files in `src/app` directory.

lib/sky-pages-module-generator.js

@@ -60,7 +60,7 @@ function getSource(skyAppConfig) {
     runtimeProviders.push(`{
       provide: SkyAuthHttp,
       useClass: SkyAuthHttp,
-      deps: [XHRBackend, RequestOptions, SkyAppWindowRef, SkyAuthTokenProvider]
+      deps: [XHRBackend, RequestOptions, SkyAuthTokenProvider, SkyAppConfig]
     }`);
   }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@blackbaud/skyux-builder",
-  "version": "1.0.0-beta.29",
+  "version": "1.0.0-beta.30",
   "description": "Builds the output of a SKY UX application.",
   "main": "index.js",
   "scripts": {

runtime/auth-http.spec.ts

@@ -128,4 +128,16 @@ describe('SkyAuthHttp', () => {
     });
   });
 
+  /**
+   * PLEASE NOTE
+   * If this tests fails, it means you've changed the required parameters to the constructor.
+   * To successfully maintain backwards compatibility:
+   *  - make any new parameters optional
+   *  - add any new parameters to the end of the constructor
+   */
+  it('should maintain backwards compatibility if new parameters added to the constructor', () => {
+    setupInjector('');
+    expect(skyAuthHttp).toBeDefined();
+  });
+
 });

test/sky-pages-module-generator.spec.js

@@ -78,7 +78,7 @@ describe('SKY UX Builder module generator', () => {
     const expectedProvider = `{
       provide: SkyAuthHttp,
       useClass: SkyAuthHttp,
-      deps: [XHRBackend, RequestOptions, SkyAppWindowRef, SkyAuthTokenProvider]
+      deps: [XHRBackend, RequestOptions, SkyAuthTokenProvider, SkyAppConfig]
     }`;
 
     let source = generator.getSource({