Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Fixed deps + test #171

Merged
merged 3 commits into from
Jun 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# 1.0.0-beta.29 (2017-06-05)

- Bugfix for `SkyAuthHttp`. [#171](https://github.com/blackbaud/skyux-builder/pull/171)

# 1.0.0-beta.29 (2017-06-05)

- Implemented style loader to resolve FOUC (flash of unstyled content). [#166](https://github.com/blackbaud/skyux-builder/pull/166)
- Initial creation of `skyRouterLink` directive. [#159](https://github.com/blackbaud/skyux-builder/pull/159)
- Updated testing suite to include internal files in `src/app` directory.
Expand Down
2 changes: 1 addition & 1 deletion lib/sky-pages-module-generator.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function getSource(skyAppConfig) {
runtimeProviders.push(`{
provide: SkyAuthHttp,
useClass: SkyAuthHttp,
deps: [XHRBackend, RequestOptions, SkyAppWindowRef, SkyAuthTokenProvider]
deps: [XHRBackend, RequestOptions, SkyAuthTokenProvider, SkyAppConfig]
}`);
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blackbaud/skyux-builder",
"version": "1.0.0-beta.29",
"version": "1.0.0-beta.30",
"description": "Builds the output of a SKY UX application.",
"main": "index.js",
"scripts": {
Expand Down
12 changes: 12 additions & 0 deletions runtime/auth-http.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,16 @@ describe('SkyAuthHttp', () => {
});
});

/**
* PLEASE NOTE
* If this tests fails, it means you've changed the required parameters to the constructor.
* To successfully maintain backwards compatibility:
* - make any new parameters optional
* - add any new parameters to the end of the constructor
*/
it('should maintain backwards compatibility if new parameters added to the constructor', () => {
setupInjector('');
expect(skyAuthHttp).toBeDefined();
});

});
2 changes: 1 addition & 1 deletion test/sky-pages-module-generator.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe('SKY UX Builder module generator', () => {
const expectedProvider = `{
provide: SkyAuthHttp,
useClass: SkyAuthHttp,
deps: [XHRBackend, RequestOptions, SkyAppWindowRef, SkyAuthTokenProvider]
deps: [XHRBackend, RequestOptions, SkyAuthTokenProvider, SkyAppConfig]
}`;

let source = generator.getSource({
Expand Down