feature/add bioimage #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianWhitneyAI
approved these changes
Jul 3, 2023
BrianWhitneyAI
approved these changes
Jul 13, 2023
toloudis
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #4
Description of Changes
This adds the main interface of the
aicsimageiopackageAICSImageasBioImage(feel free to suggest other names). It was taken directly fromaicsimageiowith the exception of the following:determine_readernow relies on plugin information fromplugins.pyget_image_dask_dataandget_image_datahas an addition to the condition that shortcuts its return of data without reshaping to check the kwargs too (seemed like a tiny bug?)In order to accomplish this I had to add a test script that is largely also taken from
aicsimageioalong with a dummy writer placeholder.Testing
I tested this using the unit tests I added and a dummy reader, needs further testing with the TIFF reader plugin