-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to supported version and update travis config #50
Conversation
acrobat
commented
Jun 25, 2017
•
edited
Loading
edited
- removed a useless test as we are testing symfony behavior and this is already covered in tests of the symfony framework itself
- SYMFONY_VERSION=2.6.* | ||
- SYMFONY_VERSION=2.7.* | ||
- SYMFONY_VERSION=2.8.* | ||
- SYMFONY_VERSION=3.0.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for removing the multiple symfony version test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to test each symfony version because of their BC policy. So testing with the composer flag --prefer-lowest
will give us symfony 2.7.* components and with a normal update it will give us the highest stable component versions. So this way we got everything covered with minimal tests. If I don't overlook anything of course :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK that BC promise has been broken a few times (think about the form component changes around 2.4-2.6)
I checked other libraries and there seem to be a trend to remove these kind of tests, so you might be right after all.
For reference, here is HTTPlug Bundle's travis config, which is kind of a midway: https://github.com/php-http/HttplugBundle/blob/master/.travis.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I wanted to check on that bundle! I will update the PR to added some extra tests like in the HTTPlugBundle!
a8fc189
to
2f86640
Compare
@sagikazarmark I've tweaked the travis config by reference of the HTTPlugBundle config |
2f86640
to
f7fe9a6
Compare