Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to supported version and update travis config #50

Merged
merged 2 commits into from
Jun 28, 2017

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Jun 25, 2017

  • removed a useless test as we are testing symfony behavior and this is already covered in tests of the symfony framework itself

- SYMFONY_VERSION=2.6.*
- SYMFONY_VERSION=2.7.*
- SYMFONY_VERSION=2.8.*
- SYMFONY_VERSION=3.0.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing the multiple symfony version test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to test each symfony version because of their BC policy. So testing with the composer flag --prefer-lowest will give us symfony 2.7.* components and with a normal update it will give us the highest stable component versions. So this way we got everything covered with minimal tests. If I don't overlook anything of course :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK that BC promise has been broken a few times (think about the form component changes around 2.4-2.6)

I checked other libraries and there seem to be a trend to remove these kind of tests, so you might be right after all.

For reference, here is HTTPlug Bundle's travis config, which is kind of a midway: https://github.com/php-http/HttplugBundle/blob/master/.travis.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes I wanted to check on that bundle! I will update the PR to added some extra tests like in the HTTPlugBundle!

@acrobat acrobat force-pushed the requirement-tweaks branch from a8fc189 to 2f86640 Compare June 27, 2017 18:26
@acrobat
Copy link
Member Author

acrobat commented Jun 27, 2017

@sagikazarmark I've tweaked the travis config by reference of the HTTPlugBundle config

@acrobat acrobat force-pushed the requirement-tweaks branch from 2f86640 to f7fe9a6 Compare June 27, 2017 18:31
@acrobat acrobat merged commit dec3a0f into bernardphp:master Jun 28, 2017
@acrobat acrobat deleted the requirement-tweaks branch June 28, 2017 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants