Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to supported version and update travis config #50

Merged
merged 2 commits into from
Jun 28, 2017
Merged

Update dependencies to supported version and update travis config #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0a7d59
Update dependencies to supported version and update travis config
acrobat Jun 25, 2017
f7fe9a6
Removed useless test
acrobat Jun 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,33 @@
sudo: false
dist: trusty

language: php

php:
- 5.5
- 5.6
- 7.0
- 7.1
- hhvm

env:
- SYMFONY_VERSION=2.3.*
- SYMFONY_VERSION=2.4.*
- SYMFONY_VERSION=2.5.*
- SYMFONY_VERSION=2.6.*
- SYMFONY_VERSION=2.7.*
- SYMFONY_VERSION=2.8.*
- SYMFONY_VERSION=3.0.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing the multiple symfony version test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to test each symfony version because of their BC policy. So testing with the composer flag --prefer-lowest will give us symfony 2.7.* components and with a normal update it will give us the highest stable component versions. So this way we got everything covered with minimal tests. If I don't overlook anything of course :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK that BC promise has been broken a few times (think about the form component changes around 2.4-2.6)

I checked other libraries and there seem to be a trend to remove these kind of tests, so you might be right after all.

For reference, here is HTTPlug Bundle's travis config, which is kind of a midway: https://github.com/php-http/HttplugBundle/blob/master/.travis.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes I wanted to check on that bundle! I will update the PR to added some extra tests like in the HTTPlugBundle!

matrix:
fast_finish: true
include:
- php: 5.6
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest"
- php: 7.1
env: DEPENDENCIES=dev
- php: 7.0
env: SYMFONY_VERSION=2.8.* # Test against LTS versions

before_install:
- if [ "$SYMFONY_VERSION" != "" ]; then composer require "symfony/symfony:${SYMFONY_VERSION}" --no-update; fi;
- if [ "$DEPENDENCIES" = "dev" ]; then perl -pi -e 's/^}$/,"minimum-stability":"dev"}/' composer.json; fi;

before_install:
- composer self-update

install:
- composer require symfony/framework-bundle:${SYMFONY_VERSION} --no-update
- composer require symfony/console:${SYMFONY_VERSION} --no-update
- composer require symfony/finder:${SYMFONY_VERSION} --no-update
- composer install --no-progress --no-plugins
- travis_retry composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction

script:
- bin/phpunit
56 changes: 0 additions & 56 deletions Tests/BernardBundleTest.php
View file
Open in desktop

This file was deleted.

11 changes: 6 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@
},

"require" : {
"bernard/bernard" : "1.0.*@dev",
"symfony/framework-bundle" : "~2.3|~3.0"
"php": "^5.6|^7.0",
"bernard/bernard": "1.0.*@dev",
"symfony/framework-bundle": "^2.7|^3.0"
},

"require-dev" : {
"symfony/console" : "~2.3|~3.0",
"symfony/finder" : "~2.3|~3.0",
"phpunit/phpunit" : "~4.0"
"symfony/console": "^2.7|^3.0",
"symfony/finder": "^2.7|^3.0",
"phpunit/phpunit": "~4.0"
},

"extra" : {
Expand Down