Implement a bernard panel for the symfony webprofiler #54

acrobat · 2017-07-12T18:06:27Z

#50 This PR adds a toolbar item and profiler section for produced messages. A message count and distinct queue count. The profiler section shows a summary of all produced messages and you can view a dump representation of the message object

TODO:

Fix the toolbar logo (I currently used the cache logo). Can anyone help and provide a svg for this? Thanks @franmomu

Screenshots:

henrikbjorn · 2017-07-13T08:20:38Z

Thats pretty cool looking 👍 I'll let somebody else okay the code.

fbourigault

Nice work! However I sent a few suggestion to improve the profiler.
Also, have you tried the profiler with Symfony 2.7 as the profiler was redesigned in 2.8?

fbourigault · 2017-07-17T05:25:18Z

Collector/ProducerCollector.php

+    {
+        $envelope = $event->getEnvelope();
+
+        $this->data['messages'][$event->getQueue()->__toString()][] = [


Why not using a string cast (string) $event->getQueue() here?

fbourigault · 2017-07-17T05:27:34Z

DependencyInjection/BernardExtension.php

+            return;
+        }
+
+        $definition = new Definition(ProducerCollector::class);


What about declaring this as PHP instead of conditionally loading a xml file?

I did indeed loaded the xml in an earlier version, but now I indeed use a php configuration. Or did I miss something?

Why did you moved from xml to php for the collector definition?

Oh you mean the other way around. I first had it like that but then struggled to make it conditional (wasn't much of an issue) but I refactored it to php then. I don't know if there is a preference to xml or php but I cna change it back!

As the bundle already use xml for configuring services, I think it's better to stick with it if possible. Anyone else have an opinion on this?

fbourigault · 2017-07-17T05:30:56Z

Resources/views/Collector/producer.html.twig

+{% endblock %}
+
+{% block menu %}
+    {% if collector.messageCount > 0 %}


You should not hide the menu entry if there is no messages.

fbourigault · 2017-07-17T05:31:49Z

Resources/views/Collector/producer.html.twig

+                {% endfor %}
+                </tbody>
+            </table>
+        {% endfor %}


Related to the menu block, you should add an else statement here to tell users there is no messages to show.

acrobat · 2017-07-17T11:10:29Z

@fbourigault Thanks for the review! I fixed the commented issues and I will test symfony 2.7 later today!

2 more screenshots for the profiler when no messages are produced

acrobat · 2017-07-19T06:26:40Z

I've tested the toolbar in 2.7 and it's indeed quite broken 😛 so now is the question what we should do

Use a fallback check and write specific html for 2.7 and 2.8+
bump the symfony minimum requirement to 2.8 and maintain 1 version of the toolbar.

As this is a new feature I tend more to solution 2. HttplugBundle had the same discussion and also went with bumping symfony.

/cc @fbourigault @sagikazarmark

henrikbjorn · 2017-07-19T07:41:15Z

i vote to bump it.

fbourigault · 2017-07-19T07:47:26Z

Me too. Users can safely upgrade from 2.7 to 2.8 (was our conclusion for HttplugBundle).

acrobat · 2017-07-23T12:50:15Z

Minimum symfony version bumped to 2.8. I will test the pr a bit more to make sure it all works.

Only thing left is custom svg icon. Is anyone able to create a icon for the bernard bundle?

franmomu · 2017-09-21T13:44:30Z

Based on the favicon maybe this one:

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24">
    <path fill-rule="evenodd" clip-rule="evenodd" fill="#AAAAAA " d="M24 22c0 1.1-.9 2-2 2H2c-1.1 0-2-.9-2-2V2C0 .9.9 0 2 0h20c1.1 0 2 .9 2 2v20z"/>
    <path fill-rule="evenodd" clip-rule="evenodd" fill="#222222 " d="M14.626 10.24c-1.266-.44-3.5 0-3.5 0v-3.5c0-.875.582-2.333.582-2.333L7.042 5.79v.95h1.166v12.834s5.327.076 5.327-.076c0-.146 3.423-1.75 3.423-5.174 0-2.923-1.44-3.773-2.332-4.084zm-1.75 7c-1.168 1.167-1.75 0-1.75 0v-4.666s.805-.95 1.75 0c.95.946 1.166 3.5 0 4.667z"/>
</svg>

acrobat · 2017-09-21T17:53:57Z

Thanks @franmomu, now I will be able to finish the PR! Is it possible to remove the white (lighter) block in the background so we only have the "b". And make the "b" around 17/18px in height and color #aaa. Thanks!

franmomu · 2017-09-22T08:34:50Z

Ok! Something like this:

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24">
    <path fill="#AAAAAA " d="M14.94 10.03c-1.42-.494-3.92 0-3.92 0V6.11c0-.978.653-2.61.653-2.61L6.45 5.048V6.11h1.305V20.48s5.964.086 5.964-.085c0-.164 3.83-1.96 3.83-5.792 0-3.27-1.612-4.223-2.61-4.57zm-1.96 7.836c-1.307 1.307-1.96 0-1.96 0v-5.224s.902-1.064 1.96 0c1.064 1.06 1.306 3.92 0 5.224z"/>
</svg>

acrobat · 2017-09-22T17:36:01Z

Yes, thanks a lot @franmomu!

acrobat · 2017-09-22T18:20:05Z

Rebase and squashed. @henrikbjorn @fbourigault this PR is ready for a final review!

acrobat · 2017-09-23T07:23:04Z

Let's go! 😄

sagikazarmark · 2017-09-23T20:42:59Z

Thanks for your work on this, nice thing!

acrobat force-pushed the sf-data-collector branch 5 times, most recently from 98411f7 to e911fdf Compare July 12, 2017 18:51

fbourigault reviewed Jul 17, 2017

View reviewed changes

acrobat force-pushed the sf-data-collector branch from e911fdf to fe831b6 Compare July 17, 2017 11:08

acrobat force-pushed the sf-data-collector branch from fe831b6 to e2fe183 Compare July 18, 2017 18:38

acrobat force-pushed the sf-data-collector branch from e2fe183 to adc5525 Compare July 23, 2017 12:42

fbourigault approved these changes Jul 24, 2017

View reviewed changes

Implement a bernard panel for the symfony webprofiler

7e82d6e

acrobat force-pushed the sf-data-collector branch from 793e37b to 7e82d6e Compare September 22, 2017 18:19

fbourigault approved these changes Sep 22, 2017

View reviewed changes

acrobat merged commit 2e2a146 into bernardphp:master Sep 23, 2017

acrobat deleted the sf-data-collector branch September 23, 2017 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement a bernard panel for the symfony webprofiler #54

Implement a bernard panel for the symfony webprofiler #54

acrobat commented Jul 12, 2017 •

edited

Loading

henrikbjorn commented Jul 13, 2017

fbourigault left a comment

fbourigault Jul 17, 2017

fbourigault Jul 17, 2017

acrobat Jul 17, 2017

fbourigault Jul 17, 2017

acrobat Jul 17, 2017

fbourigault Jul 17, 2017

acrobat Jul 18, 2017

fbourigault Jul 17, 2017

fbourigault Jul 17, 2017

acrobat commented Jul 17, 2017

acrobat commented Jul 19, 2017

henrikbjorn commented Jul 19, 2017

fbourigault commented Jul 19, 2017

acrobat commented Jul 23, 2017

franmomu commented Sep 21, 2017 •

edited

Loading

acrobat commented Sep 21, 2017

franmomu commented Sep 22, 2017

acrobat commented Sep 22, 2017

acrobat commented Sep 22, 2017

acrobat commented Sep 23, 2017

sagikazarmark commented Sep 23, 2017

Implement a bernard panel for the symfony webprofiler #54

Implement a bernard panel for the symfony webprofiler #54

Conversation

acrobat commented Jul 12, 2017 • edited Loading

henrikbjorn commented Jul 13, 2017

fbourigault left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acrobat commented Jul 17, 2017

acrobat commented Jul 19, 2017

henrikbjorn commented Jul 19, 2017

fbourigault commented Jul 19, 2017

acrobat commented Jul 23, 2017

franmomu commented Sep 21, 2017 • edited Loading

acrobat commented Sep 21, 2017

franmomu commented Sep 22, 2017

acrobat commented Sep 22, 2017

acrobat commented Sep 22, 2017

acrobat commented Sep 23, 2017

sagikazarmark commented Sep 23, 2017

acrobat commented Jul 12, 2017 •

edited

Loading

franmomu commented Sep 21, 2017 •

edited

Loading