Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix click event bubbling in Table::onRowClick() #1655

Merged
merged 27 commits into from
Sep 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix revert
mvorisek committed Sep 7, 2022
commit e10535033fd57f2bb75034b262dfe8fa4a139062
2 changes: 1 addition & 1 deletion src/Table.php
Original file line number Diff line number Diff line change
@@ -499,7 +499,7 @@ public function renderRow(): void

/**
* Same as on('click', 'tr', $action), but will also make sure you can't
* click outside of the body. Additionally, when you move cursor over the
* click outside of the body. Additionally when you move cursor over the
* rows, pointer will be used and rows will be highlighted as you hover.
*
* @param JsChain|\Closure|JsExpressionable $action Code to execute