Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix click event bubbling in Table::onRowClick() #1655

Merged
merged 27 commits into from
Sep 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
mvorisek committed Sep 7, 2022
commit 31153e3b704122b1042ff9ffc574041f3c88e761
2 changes: 1 addition & 1 deletion demos/_unit-test/grid-rowclick.php
Original file line number Diff line number Diff line change
@@ -29,5 +29,5 @@
// TODO emulate for all tests automatically in our Atk4\Ui\Behat\Context
$grid->table->js(true)->find('a')->on(
'click',
new JsFunction([], [new JsExpression('window.location.href = \'#test\'; event.preventDefault();')])
new JsFunction(['event'], [new JsExpression('window.location.href = \'#test\'; event.preventDefault();')])
);