-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix click event bubbling in Table::onRowClick() #1655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the issue, we need to prevent event bublibling from controls in table cells. This does not solve it, at least not automatically. Then I belive we do not even need the option to pass any selector to exlude (and for rare cases, the user can do it on it's own as the method is simple).
35f6970
to
a43c500
Compare
0192317
to
057adc3
Compare
A thought to get this finalised: Shouldn't we add a class to all links, checkboxes or other clickable items that are added to a table row, just like you did it for Whatever you guys consider best to get this released ;-) Please comment and I can adjust the code. |
We should do a generalisation by a defined class, here atk4-norowclick. |
Fixed, working now as specified - please check demo and revert demo changes in grid.php before merge |
@mkrecek234 PR looks very well made! I just need to write the test. Also, the coverage has decreased hugely. I am already on it. The problem is present since #1840. It seems there is some bug with https://github.com/sebastianbergmann/php-code-coverage itself when caching is enabled. |
Thank you @ibelar and @mkrecek234! |
fix #1601