Select sync mode dropdown with a data-testid #16053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
ambirdsall
force-pushed
the
alex/add-test-selector-for-sync-mode-dropdown
branch
from
757b821 to
85d45a3
Compare
ambirdsall
force-pushed
the
alex/add-test-selector-for-sync-mode-dropdown
branch
from
85d45a3 to
953cc4a
Compare
ambirdsall
requested review from
SofiiaZaitseva
and removed request for
a team
SofiiaZaitseva
approved these changes
Aug 29, 2022
SofiiaZaitseva
pushed a commit
that referenced
this pull request
Sep 1, 2022
SofiiaZaitseva
added a commit
that referenced
this pull request
Sep 2, 2022
* add tests for PokeAPI * Update connection.spec.ts add body verification * add page object model for update connection (poke api) test * change structure with using POM * Select sync mode dropdown with a data-testid (#16053) * Fix coments * fix goToDestinationPage signature * move fillEmail method * change structure with using POM * Fix coments * Update connection.spec.ts fix request url and schedule dropdown value Co-authored-by: Alex Birdsall <ambirdsall@gmail.com>
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* add tests for PokeAPI * Update connection.spec.ts add body verification * add page object model for update connection (poke api) test * change structure with using POM * Select sync mode dropdown with a data-testid (airbytehq#16053) * Fix coments * fix goToDestinationPage signature * move fillEmail method * change structure with using POM * Fix coments * Update connection.spec.ts fix request url and schedule dropdown value Co-authored-by: Alex Birdsall <ambirdsall@gmail.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* add tests for PokeAPI * Update connection.spec.ts add body verification * add page object model for update connection (poke api) test * change structure with using POM * Select sync mode dropdown with a data-testid (airbytehq#16053) * Fix coments * fix goToDestinationPage signature * move fillEmail method * change structure with using POM * Fix coments * Update connection.spec.ts fix request url and schedule dropdown value Co-authored-by: Alex Birdsall <ambirdsall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a
data-testidselector to the dropdown so it can be selected in cypress tests without relying on unreliable generated class names; also adjusts the strategy for selecting the dropdown option. While using adata-testidattribute is usually the best way to select parts of the UI in tests, the menu items within the dropdown are dynamically constructed by thereact-selectlibrary after being passed around multiple files: customizing this would be confusing to write and maintain. Instead, we can use the.react-select__menuclass to identify the dropdown menu (since only one will be open at a time) and usecy.containsto select specific dropdown items by their text content.