Upstream Sync #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is using the same ProtoBuf generation mechanism as OTLP traces and metrics but keeps Logs proto message definition in this repo for now, during the experimentation phase. Once we settle on a certain proto format for logs this will be proposed as official extension of Logs in OTLP. This change also generates in-memory structs for logs using pdatagen. TODO: Body needs to implement than `any` data type that Log Data Model requires. It will be done in a future PR. I want to align AttributeKeyValue in OTLP with `any` value first.
The MatchSpan interface is used by the attributes/span processor, however this change does not change the yaml configuration or behavior, just implementation. FilterSet has the same filtering logic as MatchSpan previously had, but operates more generically on just strings instead of spans and adds some additional options, such as caching. **Link to tracking Issue:** Side effect of open-telemetry#560 to help keep metrics and trace processors using matching configs the same. **Testing:** unit tests updated, no new behavior, just implementation swapout
Resolves open-telemetry#1033 We would like to use this in Jaeger `all-in-one` component that combines OTEL collector and Jaeger query in a single executable. Since the OTEL service listens on multiple terminations signals: `sigterm` and `asyncErrorChannel` we need an aggregated way to notify our service that shutdown is initiated and when it's done. ```go // query runs in a separate goroutine. queryServer, tracerCloser := startQuery(v, logger, storageFactory, svc.ReportFatalError) for state := range svc.GetStateChannel() { switch state { case service.ClosingDown: queryServer.Close() tracerCloser.Close() case service.Closed: return } } ```
…ry#1057) LogService will be used for OTLP/gRPC. Request/response messages will be used for OTLP/gRPC and OTLP/HTTP. Resolves open-telemetry#1052
* Add batching for metrics * Update documentation * Improve test coverage
* Refactor SecureReceiverSettings to use TLSSetting * Address test code coverage failure * Update file to use new license format * Address few small comments
…metry#993) * Remove extra send/receive annotations with using zipkin v1 Fixes open-telemetry#960 * Update test to use assert.EqualValues
add some tests for the zipkin status mapper
# Conflicts: # translator/trace/zipkin/status_code_test.go
# Conflicts: # receiver/zipkinreceiver/trace_receiver.go
christopher-taormina-zocdoc
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring up to date with upstream repo
pull in two of my open prs
@Zocdoc/platform