Expose service's status channel #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
+ Coverage 86.33% 86.35% +0.02%
==========================================
Files 199 199
Lines 14072 14078 +6
==========================================
+ Hits 12149 12157 +8
+ Misses 1461 1460 -1
+ Partials 462 461 -1
Continue to review full report at Codecov.
|
owais
reviewed
May 28, 2020
|
@pavolloffay can you clarify how this is intended to be used? If you can please show the code that will use it. |
|
We would like to use this in Jaeger Since the OTEL service listens on multiple terminations signals: // query runs in a separate goroutine.
queryServer, tracerCloser := startQuery(v, logger, storageFactory, svc.ReportFatalError)
for state := range svc.GetStateChannel() {
switch state {
case service.ClosingDown:
queryServer.Close()
tracerCloser.Close()
case service.Closed:
return
}
} |
|
@tigrannajaryan I will fix the coverage once we agree on the implementation. |
|
@pavolloffay approach LGTM. |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
state-channel
branch
from
4922414 to
f9989b9
Compare
|
It should be ready for review. |
tigrannajaryan
approved these changes
May 29, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
Resolves open-telemetry#1033 We would like to use this in Jaeger `all-in-one` component that combines OTEL collector and Jaeger query in a single executable. Since the OTEL service listens on multiple terminations signals: `sigterm` and `asyncErrorChannel` we need an aggregated way to notify our service that shutdown is initiated and when it's done. ```go // query runs in a separate goroutine. queryServer, tracerCloser := startQuery(v, logger, storageFactory, svc.ReportFatalError) for state := range svc.GetStateChannel() { switch state { case service.ClosingDown: queryServer.Close() tracerCloser.Close() case service.Closed: return } } ```
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Renaming OTEL_RESOURCE_LABELS env var As per the specification here open-telemetry/opentelemetry-specification#758 * update changelog
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com
Description:
Resolves #1033
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>