Remove extra send/receive annotations with using zipkin v1 #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-smith-zocdoc
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
chris-smith-zocdoc
force-pushed
the
cs_960
branch
from
6770593 to
c2e9f2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 85.68% 85.54% -0.14%
==========================================
Files 184 184
Lines 13061 13063 +2
==========================================
- Hits 11191 11175 -16
- Misses 1419 1436 +17
- Partials 451 452 +1
Continue to review full report at Codecov.
|
|
@chris-smith-zocdoc please sign the Contributor License Agreement |
|
I signed it |
|
Was there anything else blocking this? |
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…metry#993) * Remove extra send/receive annotations with using zipkin v1 Fixes open-telemetry#960 * Update test to use assert.EqualValues
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Update release docs Clean up language and include directions to handle the Changelog during a release. * Fix grammar
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* update-deps: support 1.16 go mod tidy * Update Collector deps to v0.40.0
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960