Issue 144 #1
Closed
Issue 144 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-io#5610) * Increase CDP timeout to 20 seconds; add logs after 5 seconds * update error messages
* fix not sending click event * add issue comment * slightly less messy code * refactor, use term "phase"
Decaffeinate chai.coffee and assertions_spec.coffee.
* allow same version when building npm package on Circle * check next dev version from node script * print current package version for complete info
* merge all events in one table, cleanup keyboard events * fix tests * reorder table columns, address feedback * set Typed col to user passed input
* remove accidentally added screenshots * create driver gitignore
* Clone setCookie options instead of mutating * Clone command options in runCommand * Revert "Clone command options in runCommand" This reverts commit 0e5aeb1. Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
* ADDED: missing call signatures for right/dblclick These two call signatures where missing for rightclick and dblclick: only the `rightclick(options?: Partial<ClickOptions>): Chainable<Subject> ` one was present. See cypress-io#5617 * FIXED: typo * FIXED: dtslint errors
…-io#5603) * Use win.destroy to destroy windows, log more events * fix test * Add tests for onbeforeunload, beforeunload exiting successfully * add window.open beforeunload tests * beforeunload, not beforeload * just destroy those child windows
* Catch stray reads/writes on destroyed stream_buffers * tsify stream_buffer to catch anything else like this
…ress-io#5478) * Add a bunch of extra tests in 2_cookies_spec * Try not doing weird things to cookies * if cypress.env.debug is set, log command execution thru server * improve elctron logging - we missed this when doing cri-client logging * make video_capture frames part of verbose * cleanup * use the data from getCookie to run deleteCookies * fix screenshots * still resolve with cleared cookie * cy.getcookie now gets ALL cookies from ALL domains * return Promise for followRedirect, not req.init wrap * allow passing domain: null to cy.getCookies to get all * update request_spec to be clearer * still need to call followRedirect option during sendStream * beautify the e2e tests * correct e2e test + snapshot * always discard default ports when get/set buffer - fixes cypress-io#5367 * make cy.clearCookies({ domain: null }) clear ALL cookies * update spec * use string url as key * rebalance some e2e tests to make time for new cookies e2e tests * always add default port to buffer url * jk, remove default port * set hostOnly: true when appropriate when setting cookies back on visit * update tests * Revert "if cypress.env.debug is set, log command execution thru server" This reverts commit 623ed44. * try to clean diff, cookies_no_baseurl didnt change * WIP move the expected cookies array out of snapshot and expect inline * finish updating tests * add missing snapshot * remove useless onstdout Co-authored-by: Brian Mann <brian.mann86@gmail.com>
* write failing test for login modal not closing during project setup * add closeLogin, openLogin to authStore * update test to click Continue before setup can proceed * add event listeners to fix this strange modal flow
…o#5313) * fix: give proper error message when err.stack is undefined * fix lint * update snapshot * update test to fail w/o src changes
* Fixed backface visibility. * Show reason. * Reorganized logic.
…:TomCaserta/cypress into issue-144
…:TomCaserta/cypress into issue-144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.