merge all console events in one table

[kuceb]

• log all events for mouse commands in one table, instead of three
• keep keyboard events separate, but redesign the output and col names
  fix when logging command in console, print all events in one table #5553

User facing changelog

• improve user experience around inspecting events fired during click and type commands when logging command in console, print all events in one table #5553

Additional details

How has the user experience changed?

• we now show all mouse related events in one table in console, in order
• we have more detailed information on the type command in the console

outdated screenshots

PR Tasks

• add screenshots of table
• no link to issue needed / not a regression
• reorder columns, add Details column, rename columns
• make 'Typed' column show exactly what was input to command

• Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?
• [NA] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3479 • 0 • 46 • 0

---

Run details

Project	cypress
Status	Passed
Commit	165206e
Started	Nov 6, 2019 7:17 PM
Ended	Nov 6, 2019 7:21 PM
Duration	04:11 💡
OS	Linux Debian - 9.8
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

This is much clearer - and addresses my earlier concerns of not being able to tell the order in which events were occuring.

[kuceb]

I should probably re-order the columns, and rename "Event.Target" to "Target Element"

[brian-mann]

Mouse Events

• index
• Event Type
• Target Element
• Prevented Default
  • null
  • true
• Stopped Propagation
  • null
  • true
• Active Modifiers
  • null
  • string

Keyboard Events

• index

• Typed

• Target Element

• Events Fired

• Details

  • { code: '...', which: '... }

• Prevented Default

  • null
  • true

• Active Modifiers

  • null
  • string

• Use {cmd} and {option} when literally typed in the Typed column.

• keydown, keyup, keyup, keyup on the final type needs to be split up and each independent keyboard event needs its own entry

[brian-mann]

These changes look perfect