Properly close login modal during project setup

[jennifer-shehane]

• Closes Clicking on "set up project to record" then closing "log in" modal leaves modal backdrop covering app in 3.5.0 #5631

User facing changelog

Fixed a bug where Cypress would appear frozen after cancelling user login while in the "Runs" tab.

Additional details

• Previously, there were 2 overlapping modals, even once the auth closed, the "setup project" was still open
• This PR makes it so that if the auth is closed without the user logging in, the "setup project" modal will never open

How has the user experience changed?

PR Tasks

• Have tests been added/updated?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3070 • 0 • 46 • 0

---

Run details

Project	cypress
Status	Passed
Commit	f8de081
Started	Nov 8, 2019 6:38 PM
Ended	Nov 8, 2019 6:41 PM
Duration	03:47 💡
OS	Linux Debian - 9.8
Browser	Chrome 73

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard