Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: stk3200: add support #8295

Closed
wants to merge 3 commits into from

Conversation

basilfx
Copy link
Member

@basilfx basilfx commented Dec 19, 2017

Contribution description

This PR add supports for the Silicon Labs STK3200.

The files are very similar to the SLTB001a already supported

Issues/PRs references

Made possible by #8139.

@basilfx basilfx added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 19, 2017
@haukepetersen
Copy link
Contributor

One thing I just noticed: when adding all the SiLabs boards, it seems to me that there are some parts of the board configuration that basically pop up in each of the PRs (e.g. LED macros, feature definitions, clock config?, more?). I think it would make sense to factor those parts out into a shared board folder, e.g. something like boards/common/silabs_devkit or similar.

You have probably the better overview on the similarities of all those boards, so do you think this is a sensible thing to do?

@basilfx
Copy link
Member Author

basilfx commented Dec 20, 2017

Currently, I only think the common features (or, at least very common) are:

  • LEDs
  • Advanced energy module (or, at least the code to enable the core features)
  • Flash scripts

What isn't (or what would cost more preprocessor lines):

  • Xtimer: I am working on the 32 bit timers supported in the newer ones (different config)
  • Peripherals: pin numbers changes
  • Clock configuration: the STK3200 uses different configuration, just like ikea-tradfri

If I would generalize it, it is easier to open one PR for all the boards IMHO. Would that be OK? Or could we first accept the PRs (than we don't get a long list of vendor files in the commits)?

(p.s. the build error is related to a bug in pwm.c of the EFM32 code).

@basilfx
Copy link
Member Author

basilfx commented Jan 28, 2018

Closing this one for a common approach that I soon will PR.

@basilfx
Copy link
Member Author

basilfx commented Feb 5, 2018

Second attempt in #8520.

I tried to generalize as much as possible, but limited it to board controller, AEM and PIC (SLTB001a only).

@basilfx basilfx deleted the feature/board_stk3200 branch February 24, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants