boards: stk3700: add support #8297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilfx
added
Platform: ARM
|
It turns I have one of this. Will test soon :) |
kYc0o
reviewed
Jan 4, 2018
| DWT->CTRL = 0x400113FF; | ||
|
|
||
| /* set TPIU prescaler to 16 */ | ||
| TPI->ACPR = 15; |
There was a problem hiding this comment.
Shouldn't be better to add some macros to the possible values of this prescaler?
| /* unlock ITM and output data */ | ||
| ITM->LAR = 0xC5ACCE55; | ||
| ITM->TCR = 0x10009; | ||
| } |
There was a problem hiding this comment.
Also for this "magic" numbers I'd prefer to use macros.
|
Thanks @kYc0o. I'll look into the issues. Also, @haukepetersen prefers to have a |
|
Closing this one for a common approach that I soon will PR. |
|
New attempt in #8520. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR add supports for the Silicon Labs STK3700.
The files are very similar to the SLTB001a already supported
Issues/PRs references
Made possible by #8139.