Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/stk3200: add support #12353

Merged
merged 6 commits into from
Oct 6, 2020
Merged

boards/stk3200: add support #12353

merged 6 commits into from
Oct 6, 2020

Conversation

basilfx
Copy link
Member

@basilfx basilfx commented Oct 1, 2019 •
edited
Loading

Contribution description

This PR add supports for the Silicon Labs STK3200, which I already PR'd before in #8295 and #8832. The files are similar to the SLTB001a and STK3600, STK3700 and SLSTK3401a already supported. This is a Cortex M0+ based board, with a low-power memory LCD that is supported by U8g2. The board has only 32KiB of flash, so most tests have been ignored.

Issues/PRs references

#8832
#8295

@basilfx basilfx added Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Oct 1, 2019
@basilfx basilfx requested a review from dylad October 1, 2019 20:57
@basilfx basilfx force-pushed the feature/efm32_stk3200_v2 branch 3 times, most recently from bcb25db to 18f75ec Compare October 1, 2019 22:37
@basilfx basilfx changed the title Feature/efm32 stk3200 v2 board/stk3200: add support Oct 2, 2019
@basilfx basilfx changed the title board/stk3200: add support boards/stk3200: add support Oct 2, 2019
@basilfx basilfx force-pushed the feature/efm32_stk3200_v2 branch 2 times, most recently from 159a05a to 3c9ce60 Compare October 2, 2019 10:58
@dylad
Copy link
Member

dylad commented Oct 2, 2019

@basilfx UART TX seems to work but I cannot interact with the shell, is RX working on your side ?

dylad
dylad previously requested changes Oct 2, 2019
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manage to get shell working with this fix

boards/stk3200/include/board.h
* via the USB port.
* @{
*/
#define BC_PIN GPIO_PIN(PA, 9)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define BC_PIN GPIO_PIN(PA, 9)
#define BC_PIN GPIO_PIN(PD, 7)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does make sense, according to the manual. But it's strange that it does work for me. I'll try as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this breaks RX for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema is contradicting

@basilfx
Copy link
Member Author

basilfx commented Oct 2, 2019

Shell is working for me (without the fix).

image

I have BRD 2010A Rev. B00.

@dylad
Copy link
Member

dylad commented Oct 3, 2019

This is so weird.
I have BRD 2010A Rev B00 too
PCB rev: PCB2010 REVB02

@dylad
Copy link
Member

dylad commented Oct 3, 2019

run compile_and_test_for_board.py script all night, here are the results:

- [tests/cpp11_mutex](tests/cpp11_mutex/test.failed)
- [tests/events](tests/events/test.failed)
- [tests/periph_flashpage](tests/periph_flashpage/test.failed)
- [tests/pkg_hacl](tests/pkg_hacl/test.failed)
- [tests/pkg_ubasic](tests/pkg_ubasic/test.failed)
- [tests/pthread_barrier](tests/pthread_barrier/test.failed)
- [tests/pthread_cleanup](tests/pthread_cleanup/test.failed)
- [tests/pthread_cooperation](tests/pthread_cooperation/test.failed)
- [tests/pthread_tls](tests/pthread_tls/test.failed)
- [tests/shell](tests/shell/test.failed)
- [tests/stdin](tests/stdin/test.failed)
- [tests/sys_arduino](tests/sys_arduino/test.failed)
- [tests/xtimer_msg](tests/xtimer_msg/test.failed)
- [tests/xtimer_periodic_wakeup](tests/xtimer_periodic_wakeup/test.failed)

@dylad dylad dismissed their stale review October 4, 2019 17:44

Update board controller firmware to lastest version with Simplicity Studio fixes my issue.

@basilfx basilfx force-pushed the feature/efm32_stk3200_v2 branch from 3c9ce60 to a6acf0d Compare October 16, 2019 19:37
benpicco
benpicco reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to rebase when #10475 is merged.
There is a large chunk of vendor files, but the actual board support is pretty straightforward.

@benpicco
Copy link
Contributor

@basilfx want to give this a rebase?`

@benpicco
Copy link
Contributor

benpicco commented Oct 2, 2020

This one is pretty much good to go.
Just needs a rebase 😃

Btw.: Where did you get the vendor files? I'm looking for the ones for EFR32MG1B 😇

Since the last two commits cause a lot of conflicts, just drop those and run

./dist/tools/insufficient_memory/add_insufficient_memory_board.sh stk3200

@benpicco benpicco force-pushed the feature/efm32_stk3200_v2 branch from a6acf0d to 17029eb Compare October 2, 2020 13:27
@benpicco benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 2, 2020
@benpicco benpicco force-pushed the feature/efm32_stk3200_v2 branch 3 times, most recently from 6f99dd1 to 099bcf2 Compare October 2, 2020 14:17
@basilfx basilfx requested a review from MrKevinWeiss as a code owner October 2, 2020 14:17
@benpicco benpicco requested a review from benemorius October 2, 2020 14:19
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 2, 2020
This was referenced Oct 5, 2020
Merged
Merged
@benpicco benpicco force-pushed the feature/efm32_stk3200_v2 branch from 4f8df38 to 6e6ddac Compare October 6, 2020 14:44
benpicco
benpicco approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, added Kconfig and fixed the merge conflict.
The LETIMER fix was merged independent from this, so this should be good 😇

@benpicco benpicco merged commit 6c3a0eb into RIOT-OS:master Oct 6, 2020
@basilfx basilfx deleted the feature/efm32_stk3200_v2 branch October 20, 2020 18:59
@benpicco benpicco mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@dylad dylad dylad left review comments

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@benemorius benemorius Awaiting requested review from benemorius

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basilfx @dylad @benpicco