Wasm v8 wip #3
Closed
Wasm v8 wip #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8278) Signed-off-by: Lizan Zhou <lizan@tetrate.io>
envoyproxy#8288) Signed-off-by: Xin Zhuang <stevenzzz@google.com>
envoyproxy#8091) Signed-off-by: Dan Zhang <danzh@google.com>
…nvoyproxy#8152) Currently, if gRPC config stream disconnected while Envoy waiting for initial xDS response, xDS implementations' onConfigUpdateFailed() will allow Envoy startup to continue. This may cause Envoy begins taking traffics while route/cluster/endpoint config are still missing and return "404 NR" or "503 NR". This change makes Envoy waiting for initial xDS response until initial_fetch_timeout if specified. Risk Level: Medium Testing: existing test cases updated Fixes envoyproxy#8046 Signed-off-by: lhuang8 <lhuang8@ebay.com>
Adds a script to create a go module from the generated protobufs as part of envoyproxy#8151. The module appears to build with the following module declaration: module github.com/envoyproxy/data-plane-api/api go 1.12 require ( github.com/census-instrumentation/opencensus-proto v0.2.1 github.com/envoyproxy/protoc-gen-validate v0.1.0 github.com/gogo/protobuf v1.3.0 github.com/golang/protobuf v1.3.2 github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4 google.golang.org/genproto v0.0.0-20190819201941-24fa4b261c55 google.golang.org/grpc v1.23.0 ) Add CI automation to trigger the script after the merge to master in envoyproxy. Risk Level: low Testing: local build Docs Changes: none Release Notes: none Fixes envoyproxy#8151 Signed-off-by: Kuat Yessenov <kuat@google.com>
…xy#3383) (envoyproxy#8009) When trailer indicates a gRPC error and there was no HTTP body, with the `convert_grpc_status option` enabled, take `google.rpc.Status` from the `grpc-status-details-bin` header and use it as a JSON body. If there was no such header, make `google.rpc.Status` out of the `grpc-status` and `grpc-message` headers. This also adds `google.rpc.Status` to user-provided protobuf descriptor. Risk Level: Small-medium Testing: Added unit and integration tests tests, tested manually. Docs Changes: Added field description in api/envoy/config/filter/http/transcoder/v2/transcoder.proto Release Notes: Fixes envoyproxy#3383 Signed-off-by: Anatoly Scheglov <ascheglov@yandex-team.ru>
Fixes To: field of security email templates Risk level: Low Testing: n/a Doc Changes: yes Release Notes: n/a Signed-off-by: Asra Ali <asraa@google.com>
Adds a debug log line when a cluster is skipped from CDS response. Risk Level: Low (debug logging) Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Some example regexes were rendered incorrectly on envoyproxy.io. I chose to try to find all the example regexes and make them literal text. This way the regexes are syntactically correct both in the raw proto and on the doc site. Also found an H2 protocol option with a missing paragraph due to a blank line vs. empty comment line. Risk: low, comment-only Testing: n/a Docs: updated Release Notes: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
… lookup, which should have a fallback and avoid locks (envoyproxy#8243) * Split StatNameSet API into explicit Dynamic and Builtin requests, with a required fallback stat-name for Builtins rather than a potential lock. Signed-off-by: Joshua Marantz <jmarantz@google.com>
…nvoyproxy#8300) * Move trailing detached comments that protoc ignores to some anchored place. In the near future, this will be enforced by check_format. * Remove comments on reserved fields; we won't be using reserved in v3 and it's a bit of a pain preserving them. Risk level: Low Testing: Docs build, diff inspection, comparison against output of proto transform tool. Signed-off-by: Harvey Tuch <htuch@google.com>
…ny recursively (envoyproxy#8231) Use TextFormat::Print with SetExpandAny(true) instead of SerializeAsString to calculate hash with Any expanded. Risk Level: Med Testing: CI, regression test Fixes envoyproxy#5744. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext Risk Level: low Testing: unit tests Signed-off-by: Elisha Ziskind <eziskind@google.com>
This PR adds fields to CDS that allow for configuring LRS. Risk Level: Low Testing: None (but if anything is needed, please let me know) Docs Changes: Inline with API protos Signed-off-by: Mark D. Roth <roth@google.com>
This PR does a few things: 1) Adds per-worker listener stats, useful for viewing worker connection imbalance. 2) Adds per-worker watchdog miss stats, useful for viewing per worker event loop latency. 3) Misc connection handling cleanups. Part of envoyproxy#4602 Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Mark D. Roth <roth@google.com>
…roxy#8311) Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Mark D. Roth <roth@google.com>
This patch introduces a new tool, protoxform, that will be the basis of the v2 -> v3 migration tooling. It operates as a Python protoc plugin, within the same framework as protodoc, and provides the ability to operate on protoc AST input and generate proto output. As a first step, the tool is applied reflexively on v2, and functions as a formatting tool. In later patches, this will be added to check_format/fix_format scripts and CI. Part of envoyproxy#8082. Risk level: medium (it's possible that some inadvertent wire changes occur, if they do, this patch should be rolled back). Testing: manual inspection of diff, bazel test //test/..., some grep/diff scripts to ensure we haven't lost any comments. Signed-off-by: Harvey Tuch <htuch@google.com>
* Separate out grpc init to a separate class. Signed-off-by: Joshua Marantz <jmarantz@google.com>
As discussed on envoyproxy#8078 absolute URLs are part of the HTTP/1 spec and the code has been used for some time now - turning it up by default. Risk Level: Medium (changes to L7 for many users) Testing: updated tests for new defaults Docs Changes: no Release Notes: yes Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This updates rules_foreign_cc to include bazel-contrib/rules_foreign_cc#318 The patch may fix some OSS-Fuzz build failures related to transitive dependencies in curl coming from envoyproxy#8154 Risk level: Low Signed-off-by: Asra Ali <asraa@google.com>
This will introduce another platform (apart from oss) fuzz that will run the long-running fuzzers as well as will introduce "sanity fuzzers" that will run the accumlated corpus and crashes on every Pull-Request to detect bugs early-on in the development cycle. Risk Level: Low - as this will introduce only another step in CircleCI where the fuzzers will be uploaded to Fuzzit and the heavy lifting will be there. Testing: No code is added just a CI code in Circle Signed-off-by: Yevgeny Pats <yp@fuzzit.dev>
* ci: add protoxform as a check/fix_format step. Part of envoyproxy#8082. Signed-off-by: Harvey Tuch <htuch@google.com>
…nvoyproxy#8335) Part of envoyproxy#8082. Signed-off-by: Harvey Tuch <htuch@google.com>
API for envoyproxy#8016 Customers adopting service mesh likes mTLS ability. However, rolling it out without breaking existing traffic is hard. This is because mTLS is configured on per cluster basis. In reality, a service consists of multiple endpoints, mixed with having Envoy sidecar and without-sidecar endpoints. Client envoy can't send mTLS traffic until all server migrated to having Envoy sidecar. This API tries to solve the issue by allowing mTLS/transport socket to configured at finer granularity, e.g. endpoint level. The endpoint has metadata label information, which will be used to decide which transport socket configuration to use from a map specified in the cluster. So the outcome is that, xDS management server is able to configure client envoy talks to endpoints with sidecar in mTLS and plain text to endpoints without sidecar, for a single cluster. Description: Risk Level: N/A (API change only) Release Notes: Cluster API change to use different transport socket based on endpoint label. Signed-off-by: Jianfei Hu <jianfeih@google.com>
Handling deprecated and deprecated-default enum values as part of our config checking. Risk Level: Medium Testing: new unit tests Docs Changes: updated runtime docs Release Notes: reverted envoyproxy#8207 Fixes envoyproxy#8253 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
envoyproxy#8309 and envoyproxy#8100 collided Risk Level: Low (cleanup) Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Tony Allen <tallen@lyft.com>
Via ./api/migration/v3alpha.sh. This picks up the changes since the last sync, in particular the major reformat in envoyproxy#8309. Risk level: Low (not used yet). Testing: bazel build @envoy_api//... Signed-off-by: Harvey Tuch <htuch@google.com>
ssl_redirect on external only is not doing as declared The reason is that it doesn't determines whether the request is internal in the common approach. Expect: check the header exists and the value is "true" as everywhere else in the code base. Risk Level: HIGH, maybe. Since require_tls: EXTERNAL_ONLY user may see different(but correct!) behavior. Testing: Unit test added. Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Description: Add a script to setup clang prebuilt packages. Risk Level: Low Testing: local, CI Docs Changes: bazel/README.md Release Notes: Fixes envoyproxy#8625 Signed-off-by: Lizan Zhou <lizan@tetrate.io>
…envoyproxy#8725) Compiler macros that define statements with semicolons, when followed by an additional semicolon, have the side-effect of producing a line of code considered unreachable by llvm-cov. This change modifies the macros to avoid this, which makes code coverage numbers slightly more accurate. Risk Level: low Testing: n/a Doc Changes: n/a Release Notes: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
… protobuf, Jinja, yaml-cpp, re2 (envoyproxy#8728) Signed-off-by: Michael Payne <michael@sooper.org>
…oxy#8522) Signed-off-by: Spencer Lewis <slewis@squareup.com>
envoyproxy#8581) Signed-off-by: Lisa Lu <lisalu@lyft.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
…voyproxy#8499) Adds a configuration option that will convert all header keys into Proper-Case. This is useful to allow Envoy to respond with headers that match the casing of other systems, to ensure that the wire format of responses is unchanged when migrating to Envoy. Fixes envoyproxy#8463 Signed-off-by: Snow Pettersen <snowp@squareup.com>
Use alternate invocation for setlocale that sucessfully sets a language agnostic UTF-8 encoding as the locale. Risk Level: low Testing: n/a Doc Changes: n/a Release Notes: n/a Fixes: envoyproxy#8742 Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Adds a basic fuzzer using a FuzzedDataProvider. Risk Level: low Testing: just the new fuzzer Signed-off-by: Joshua Marantz <jmarantz@google.com>
Description: update CEL runtime to tighten the complexity bounds: - remove comprehension operators (forall, exists) - remove list and string concat to avoid memory allocation - limit RE2 regex max program size - remove string conversion to avoid string allocation Risk Level: low Testing: unit tests Docs Changes: remove upstream.mtls attribute due to ongoing envoyproxy#8464 Release Notes: Signed-off-by: Kuat Yessenov <kuat@google.com>
Allow to load EDS clusters from file before ADS requests. Now if cluster is EDS type it won't be initialized before ADS. Fixes envoyproxy#8168 Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Remove functions that are no longer needed. For details, see: - envoyproxy/envoy-wasm#260 - envoyproxy/envoy-wasm#262 - envoyproxy/envoy-wasm#263 - envoyproxy/envoy-wasm#268 Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Fixes envoyproxy#8343 Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
pushed a commit
that referenced
this pull request
Jan 9, 2022
This PR fixes two compilation error that are happening in the oss-fuzz build of Envoy. Note that the latest oss-fuzz build errors out with only the error related to AsyncStream but AFAIR when it is fixed, a different compilation error has to be fixed which I fixed in the first commit that changes the socket.h file.
Fixes an oss-fuzz Envoy compilation error:
```
Execution platform: @local_config_platform//:host
In file included from source/common/network/socket_option_impl.cc:1:
In file included from ./source/common/network/socket_option_impl.h:6:
In file included from ./envoy/network/listen_socket.h:14:
./envoy/network/socket.h:26:3: error: definition of implicit copy assignment operator for 'SocketOptionName' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
SocketOptionName(const SocketOptionName&) = default;
^
source/common/network/socket_option_impl.cc:52:14: note: in implicit copy assignment operator for 'Envoy::Network::SocketOptionName' first required here
info.name_ = optname_;
^
1 error generated.
INFO: Elapsed time: 2620.084s, Critical Path: 126.35s
INFO: 4237 processes: 154 internal, 4083 local.
FAILED: Build did NOT complete successfully
ERROR:root:Building fuzzers failed.
```
Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
* types_async_client.h: fix deprecated defaulted copy ctor
Fixes an oss-fuzz Envoy compilation error:
```
Step #3 - "compile-afl-address-x86_64": Execution platform: @local_config_platform//:host
Step #3 - "compile-afl-address-x86_64": In file included from source/extensions/filters/http/ext_proc/client_impl.cc:1:
Step #3 - "compile-afl-address-x86_64": In file included from ./source/extensions/filters/http/ext_proc/client_impl.h:11:
Step #3 - "compile-afl-address-x86_64": �[1m./source/common/grpc/typed_async_client.h:38:3: �[0m�[0;1;31merror: �[0m�[1mdefinition of implicit copy assignment operator for 'AsyncStream<envoy::service::ext_proc::v3::ProcessingRequest>' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]�[0m
Step #3 - "compile-afl-address-x86_64": AsyncStream(const AsyncStream& other) = default;
Step #3 - "compile-afl-address-x86_64": �[0;1;32m ^
Step #3 - "compile-afl-address-x86_64": �[0m�[1msource/extensions/filters/http/ext_proc/client_impl.cc:34:11: �[0m�[0;1;30mnote: �[0min implicit copy assignment operator for 'Envoy::Grpc::AsyncStream<envoy::service::ext_proc::v3::ProcessingRequest>' first required here�[0m
Step #3 - "compile-afl-address-x86_64": stream_ = client_.start(*descriptor, *this, options);
Step #3 - "compile-afl-address-x86_64": �[0;1;32m ^
Step #3 - "compile-afl-address-x86_64": �[0m1 error generated.
```
Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
* socket.h: delete default assignment operator
Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
* typed_async_client.h: remove default assignment op
Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
PiotrSikora
pushed a commit
that referenced
this pull request
Mar 16, 2022
…yproxy#20170) * test: adding a multi-envoy test (envoyproxy#20016) Functionally this handles the multi-envoy signal handler crash skips instantiating a runtime singleton (off by default, must stay off until remove global runtime: rebase runtime features on ABSL_flags envoyproxy#19847 is closed) Multi-envoy does not correctly support runtime flags or deprecation stats due to envoyproxy#19847 being incomplete. It can still handle proxy traffic client - L1 - L2 - upstream as shown in test. Risk Level: low Testing: yes Docs Changes: n/a Release Notes: n/a Part of envoyproxy/envoy-mobile#2003 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * Add a congestionWindowInBytes method to Envoy::Network::Connection (envoyproxy#20105) Signed-off-by: Bin Wu <wub@google.com> Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * Update QUICHE from 50f15e7a5 to cf1588207 (envoyproxy#20154) https://github.com/google/quiche/compare/50f15e7a5..cf1588207 $ git log 50f15e7a5..cf1588207 --date=short --no-merges --format="%ad %al %s" 2022-02-28 wub Deprecate --gfe2_reloadable_flag_quic_crypto_noop_if_disconnected_after_process_chlo. 2022-02-27 vasilvv Remove QuicheMemSlice(QuicUniqueBufferPtr, size_t) constructor. 2022-02-26 fayang Use std::string instead of absl::string_view in CryptoBufferMap. 2022-02-25 bnc Ignore incoming HTTP/3 MAX_PUSH_ID frames. 2022-02-25 bnc Remove Http3DebugVisitor::OnMaxPushIdFrameSent(). 2022-02-25 bnc Remove QuicSpdySession::CanCreatePushStreamWithId(). 2022-02-25 fayang Deprecate gfe2_reloadable_flag_quic_single_ack_in_packet2. Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * build(deps): bump actions/stale from 4.1.0 to 5 (envoyproxy#20159) Bumps [actions/stale](https://github.com/actions/stale) from 4.1.0 to 5. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v4.1.0...v5) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * admin: improve test coverage and increase the coverage-percent threshold (envoyproxy#20025) Adds a missing test for recent lookups now that there are no more fake symbol tables. Adds tests for a variety of override methods defined in admin.h that were previously hard to hit. Adds a benchmark test to establish a baseline for the speedups in envoyproxy#19693 Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * test: removing a bunch of direct runtime singleton access (envoyproxy#19993) Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * build(deps): bump grpcio-tools in /examples/grpc-bridge/client (envoyproxy#20040) Bumps [grpcio-tools](https://github.com/grpc/grpc) from 1.43.0 to 1.44.0. - [Release notes](https://github.com/grpc/grpc/releases) - [Changelog](https://github.com/grpc/grpc/blob/master/doc/grpc_release_schedule.md) - [Commits](grpc/grpc@v1.43.0...v1.44.0) --- updated-dependencies: - dependency-name: grpcio-tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds to spellcheck Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * xray tracer: set subsegment type for child spans (#2) * xray tracer: set subsegment type for child spans Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds test coverage Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * Xray subsegment (#3) * xray tracer: set subsegment type for child spans Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds test coverage Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates xray subsegment name to use operation name (instead of parent's span name) Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * Xray subsegment (#4) * xray tracer: set subsegment type for child spans Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds test coverage Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates xray subsegment name to use operation name (instead of parent's span name) Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds to spell check dictionary Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * fixes spellcheck Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds to spellcheck Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> xray tracer: set subsegment type for child spans (#2) * xray tracer: set subsegment type for child spans Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds test coverage Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> Xray subsegment (#3) * xray tracer: set subsegment type for child spans Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds test coverage Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates xray subsegment name to use operation name (instead of parent's span name) Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> Xray subsegment (#4) * xray tracer: set subsegment type for child spans Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds test coverage Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates xray subsegment name to use operation name (instead of parent's span name) Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * updates doc Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * adds to spell check dictionary Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> fixes spellcheck Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> * fixes spell check Signed-off-by: Rex Chang <58710378+rexnp@users.noreply.github.com> Co-authored-by: alyssawilk <alyssar@chromium.org> Co-authored-by: Bin Wu <46450037+wu-bin@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Marantz <jmarantz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.