server: expose ProcessContext via the Api interface #8258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elisha Ziskind <eziskind@google.com>
Signed-off-by: Elisha Ziskind <eziskind@google.com>
|
@dio can you have a look? |
|
/retest |
|
🤷♀️ nothing to rebuild. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8258 in repo envoyproxy/envoy |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dio could you take a look at this when you get a chance? |
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Sep 24, 2019
Expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext Risk Level: low Testing: unit tests Signed-off-by: Elisha Ziskind <eziskind@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext Risk Level: low Testing: unit tests Signed-off-by: Elisha Ziskind <eziskind@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext Risk Level: low Testing: unit tests Signed-off-by: Elisha Ziskind <eziskind@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: expose an optional ProcessContext in the Api interface so it is accessible to extensions that don't get a FactoryContext
Risk Level: low
Testing: unit tests
Signed-off-by: Elisha Ziskind eziskind@google.com