wasm: sync WasmVm interface with upstream. #8713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove functions that are no longer needed. For details, see: - envoyproxy/envoy-wasm#260 - envoyproxy/envoy-wasm#262 - envoyproxy/envoy-wasm#263 - envoyproxy/envoy-wasm#268 Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
Code LGTM though the coverage drop looks high |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
@lizan yeah, the issue is that the removed test was indirectly testing |
|
/retest |
|
🔨 rebuilding |
|
/retest |
|
🔨 rebuilding |
|
@lizan coverage fixed, could you re-run AZP tests and merge/approve? |
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run envoy-windows |
|
Commenter does not have sufficient privileges for PR 8713 in repo envoyproxy/envoy |
lizan
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove functions that are no longer needed. For details, see:
Signed-off-by: Piotr Sikora piotrsikora@google.com