refactor(ICache): follow new style guide #4338

ngc7331 · 2025-02-28T09:05:17Z

move InstrUncache out of package ICache (as it is actually a submodule of Ifu)
each class in a separate file (except Bundles / Utils)
module IO inside module class
extract similar codes and define them as helper functions for reuse
renames:
- camel cases
- unify bundle naming convention
- re-organize IO

XiangShanRobot · 2025-02-28T18:30:21Z

[Generated by IPC robot]
commit: 2a0373a

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`2a0373a`	1.794	0.442	2.641	1.230	2.158	1.676	2.143	2.362	0.943	1.378	1.961	3.102	2.538	2.275	3.276

master branch:

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`a67fd0f`				1.231		1.676			0.943		1.961	3.102			3.276
`0d55e1d`	1.794	0.442	2.641	1.226	2.158	1.676	2.143	2.362	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`66e9b54`	1.807	0.442	2.635	1.228	2.144	1.678	2.144	2.362	0.944	1.389	1.953	3.112	2.559	2.271	3.300
`0907eaa`	1.807	0.442	2.635	1.225	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300
`f486573`	1.807	0.442	2.635	1.235	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300
`4b2c87b`	1.807	0.442	2.635	1.232	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300
`4e7fa70`	1.807	0.442	2.635	1.232	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300
`eca6983`	1.807	0.442	2.635	1.228	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300
`4a699e2`	1.807	0.442	2.635	1.229	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300
`b6c1432`	1.807	0.442	2.635	1.220	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300

XiangShanRobot · 2025-03-03T13:44:10Z

[Generated by IPC robot]
commit: 14804c4

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`14804c4`	1.795	0.442	2.641	1.231	2.158	1.676	2.143	2.362	0.943	1.389	1.961	3.102	2.538	2.275	3.276

master branch:

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`10cfb21`	1.795	0.442	2.641	1.222	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`76cb49a`	1.797	0.442	2.641	1.232	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`f5d5a4f`	1.795		2.641	1.241	2.158	1.676	2.143		0.943	1.378	1.961	3.102		2.275	3.276
`7ea4836`	1.795	0.442	2.641	1.236	2.158	1.676	2.143	2.362	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`2caa7ef`	1.795	0.442	2.641	1.222	2.158	1.676	2.143	2.362	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`9928cec`	1.795	0.442	2.641	1.227	2.158	1.676	2.143	2.362	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`a67fd0f`	1.794	0.442	2.641	1.231	2.158	1.676	2.143	2.362	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`0d55e1d`	1.794	0.442	2.641	1.226	2.158	1.676	2.143	2.362	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`66e9b54`	1.807	0.442	2.635	1.228	2.144	1.678	2.144	2.362	0.944	1.389	1.953	3.112	2.559	2.271	3.300
`0907eaa`	1.807	0.442	2.635	1.225	2.144	1.678	2.144	2.362	0.944	1.382	1.953	3.112	2.559	2.271	3.300

XiangShanRobot · 2025-03-04T17:24:17Z

[Generated by IPC robot]
commit: 82598b7

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`82598b7`	1.795	0.442	2.641	1.237	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276

master branch:

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`d084f29`	1.794	0.442	2.641	1.230	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`e0d20e1`	1.794	0.442	2.641	1.230	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`168f199`	1.795	0.442	2.641	1.230	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`fd4d6c2`	1.797	0.442	2.641	1.228	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276
0a16c8b	1.795	0.442	2.641	1.215	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`c081b71`	1.794	0.442	2.641	1.238	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`10cfb21`	1.795	0.442	2.641	1.222	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`76cb49a`	1.797	0.442	2.641	1.232	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`f5d5a4f`	1.795		2.641	1.241	2.158	1.676	2.143		0.943	1.378	1.961	3.102		2.275	3.276

XiangShanRobot · 2025-03-06T15:10:12Z

[Generated by IPC robot]
commit: 0d46d6c

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`0d46d6c`	1.795	0.442	2.641	1.219	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276

master branch:

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`a2ecedc`	1.823	0.442	2.641	1.234	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`ac5be75`	1.822			1.242	2.158	1.676	2.144		0.940		1.972	3.112		2.272	3.300
`eaf1474`	1.823	0.442	2.641	1.228	2.158	1.676	2.144	2.364	0.940	1.389	1.972	3.112	2.538	2.272	3.300
`90f8d3c`	1.823	0.442	2.641	1.232	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`455e3b5`	1.795	0.442	2.641	1.235	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`4c91604`	1.795	0.442	2.641	1.236	2.158	1.676	2.143	2.363	0.943	1.389	1.961	3.102	2.538	2.275	3.276
`25381b7`	1.795	0.442	2.641	1.234	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`aa78128`	1.795	0.442	2.641	1.235	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`d084f29`	1.794	0.442	2.641	1.230	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276
`e0d20e1`	1.794	0.442	2.641	1.230	2.158	1.676	2.143	2.363	0.943	1.378	1.961	3.102	2.538	2.275	3.276

... as it's actually submodule of Ifu

…ldBypass

…idHold

… to ICacheCtrlUnitParams

Naming: - I/O: - ICache inner use only: xxxBundle - Other modules use: ICacheXxxBundle, consider move to FrontendBundle.scala - Sram/register: xxxEntry Try avoiding directed Bundle, unless it's req-resp pair Add ICacheToIfuIO & move resp/perf/topdown/icacheReady into it - ICacheIO.toIFU / IFUICacheIO.icacheReady -> ICacheToIfuIO.fetchReady - ICacheIO.perfInfo / NewIFUIO.icachePerfInfo -> ICacheToIfuIO.perf - ICacheMainPipeBundle.topdown.* / IFUICacheIO.topdown* -> ICacheToIfuIO.topdown.* Add IfuToICacheIO & move stall into it - NewIFUIO.icacheStop / ICacheIO.stop -> IfuToICacheIO.stall Add FtqToICacheIO - ICacheIO.fetch -> FtqToICacheIO.fetchReq - ICacheIO.ftqPrefetch / FtqToPrefetchIO -> FtqToICacheIO.prefetchReq Other renames - ICacheIO.softPrefetch -> ICacheIO.softPrefetchReq

TODO: ICacheMainPipe & ICachePrefetchPipe we need to discuss how to deal with pipeline stage signals (sx_abc)

reused by ICachePrefetchPipe & ICacheWayLookup

we allow sx_lowerCamelCase for better readability

XiangShanRobot · 2025-03-10T12:26:57Z

[Generated by IPC robot]
commit: 01719eb

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`01719eb`	1.822	0.442	2.641	1.227	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300

master branch:

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`fad7c42`		0.442	2.641			1.676		2.364		1.389			2.538
`dfb03ba`	1.822	0.442	2.641	1.234	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`d6b0a27`	1.823	0.442	2.641	1.226	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`591ae1c`	1.822	0.442	2.641	1.236	2.158	1.676	2.144	2.364	0.940	1.389	1.972	3.112	2.538	2.272	3.300
`11269ca`	1.823	0.442	2.641	1.231	2.158	1.676	2.144	2.364	0.940	1.389	1.972	3.112	2.538	2.272	3.300
`7fbc1cb`	1.823	0.442	2.641	1.233	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`0bac66c`	1.823	0.442	2.641	1.223	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`0837330`	1.822	0.442	2.641	1.231	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`ba0bece`	1.823	0.442	2.641	1.231	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`db3923f`	1.822	0.442	2.641	1.237	2.158	1.676	2.144	2.364	0.940	1.389	1.972	3.112	2.538	2.272	3.300

XiangShanRobot · 2025-03-11T10:41:36Z

[Generated by IPC robot]
commit: c936f3b

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`c936f3b`	1.806	0.442	2.641	1.233	2.150	1.676	2.149	2.364	0.933	1.389	2.010	3.108	2.538	2.274	3.309

master branch:

commit	astar	copy_and_run	coremark	gcc	gromacs	hmmer-Vector	lbm	linux	mcf	microbench	milc	namd	povray	wrf	xalancbmk
`42b75a5`			2.641	1.229		1.676			0.933	1.378					3.309
`f9395f7`	1.806	0.442	2.641	1.229	2.150	1.676	2.149	2.364	0.933	1.389	2.010	3.108	2.538	2.274	3.309
`c1eb288`	1.806	0.442	2.641	1.237	2.150	1.676	2.149	2.364	0.933	1.389	2.010	3.108	2.538	2.274	3.309
`9d7a35d`	1.822	0.442	2.641	1.228	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`fad7c42`	1.823	0.442	2.641	1.228	2.158	1.676	2.144	2.364	0.940	1.389	1.972	3.112	2.538	2.272	3.300
`dfb03ba`	1.822	0.442	2.641	1.234	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`d6b0a27`	1.823	0.442	2.641	1.226	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300
`591ae1c`	1.822	0.442	2.641	1.236	2.158	1.676	2.144	2.364	0.940	1.389	1.972	3.112	2.538	2.272	3.300
`11269ca`	1.823	0.442	2.641	1.231	2.158	1.676	2.144	2.364	0.940	1.389	1.972	3.112	2.538	2.272	3.300
`7fbc1cb`	1.823	0.442	2.641	1.233	2.158	1.676	2.144	2.364	0.940	1.378	1.972	3.112	2.538	2.272	3.300

ngc7331 changed the title ~~refactor(frontend): follow new style guide~~ refactor(ICache): follow new style guide Feb 28, 2025

ngc7331 force-pushed the refactor-icache branch from 7516977 to 87e40bd Compare February 28, 2025 09:15

ngc7331 force-pushed the refactor-icache branch 3 times, most recently from 6b6ef31 to 14804c4 Compare March 3, 2025 03:08

ngc7331 force-pushed the refactor-icache branch 3 times, most recently from 397ce33 to 82598b7 Compare March 4, 2025 11:42

ngc7331 force-pushed the refactor-icache branch from 19870e1 to 0d46d6c Compare March 6, 2025 10:58

ngc7331 added 17 commits March 10, 2025 14:16

refactor(frontend): move InstrUncache out of package icache

d017665

... as it's actually submodule of Ifu

refactor(ICache): move utils into a seperate file

748c2d2

refactor(ICache): move SRAMTemplateWithFixedWidth into seperate file

871cf63

refactor(ICache): rename ICacheBundle.scala to Bundles.scala

1e8d3c2

refactor(ICache): move abstract classes into seperate file

39ea442

refactor(ICache): move helpers into seperate file

e4138dc

refactor(ICache): remove useless IPrefetchBundle/Module

28265c3

refactor(ICache): replace icache.ResultHoldBypass with utility.DataHo…

9761bfb

…ldBypass

refactor(ICache): replace icache.generatePipeControl with utility.Val…

c01c92a

…idHold

refactor(ICache): move ICacheParams into separate file

c40e668

refactor(ICache): move ICacheReplacer into separate file

10ab49a

refactor(ICache): move ICacheImp into separate file

a864152

refactor(ICache): move bundles to Bundles.scala

4362189

refactor(ICache): move L1ICacheCtrlParams into separate file & rename…

18fbf87

… to ICacheCtrlUnitParams

refactor(ICache): move ICacheMSHR into separate file

a9982af

refactor(ICache): move Meta/DataArray into separate file

75ccdd5

refactor(Frontend): ExceptionType extends NamedUInt

08239ad

ngc7331 added 10 commits March 10, 2025 14:16

refactor(Frontend): update header & remove unused imports

b1d993d

refactor(Frontend): move module IO inside class & rename IPrefetch

18dbfd3

refactor(ICache): use camel case (WIP)

df4a802

TODO: ICacheMainPipe & ICachePrefetchPipe we need to discuss how to deal with pipeline stage signals (sx_abc)

refactor(ICache): add ICacheMissUpdateHelper to de-duplicate code

fd017d9

reused by ICachePrefetchPipe & ICacheWayLookup

refactor(ICache): getBankSel returns Vec[Vec[Bool]]

4c6e728

refactor(ICacheMissUnit): de-dup code

d207387

refactor(ICache): move checkEcc functions to ICacheEccHelper

79fceec

refactor(ICache): reformat

e47108f

fix(ICacheCtrlUnit): fix InjectFsmState width

0e44487

ngc7331 force-pushed the refactor-icache branch from 0d46d6c to 01719eb Compare March 10, 2025 06:16

ngc7331 added 3 commits March 10, 2025 14:17

refactor(ICache): apply camel case to mainPipe/prefetchPipe

617d8a2

we allow sx_lowerCamelCase for better readability

refactor(ICache): add checkMshrHit and getBankValid to de-dup code

85ce811

refactor(ICache): rename ICachePrefetchPipe s1_state

01719eb

refactor(ICache): add ICacheMetaHelper reused by PrefetchPipe & CtrlUnit

c936f3b

ngc7331 marked this pull request as ready for review March 11, 2025 10:42

ngc7331 requested review from Gao-Zeyu and eastonman as code owners March 11, 2025 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(ICache): follow new style guide #4338

refactor(ICache): follow new style guide #4338

ngc7331 commented Feb 28, 2025 •

edited

Loading

XiangShanRobot commented Feb 28, 2025

XiangShanRobot commented Mar 3, 2025

XiangShanRobot commented Mar 4, 2025

XiangShanRobot commented Mar 6, 2025

XiangShanRobot commented Mar 10, 2025

XiangShanRobot commented Mar 11, 2025

refactor(ICache): follow new style guide #4338

Are you sure you want to change the base?

refactor(ICache): follow new style guide #4338

Conversation

ngc7331 commented Feb 28, 2025 • edited Loading

XiangShanRobot commented Feb 28, 2025

XiangShanRobot commented Mar 3, 2025

XiangShanRobot commented Mar 4, 2025

XiangShanRobot commented Mar 6, 2025

XiangShanRobot commented Mar 10, 2025

XiangShanRobot commented Mar 11, 2025

ngc7331 commented Feb 28, 2025 •

edited

Loading