Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligned styles of indented components #1746

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Aligned styles of indented components #1746

merged 4 commits into from
Nov 8, 2021

Conversation

jrbarnes9
Copy link
Contributor

@jrbarnes9 jrbarnes9 commented Nov 5, 2021 •
edited
Loading

What is the context of this PR?

  • Aligned all components that use indented content with left border, to ensure the colour and width of the border are the same, and the spacing is the same.
  • Also added default bottom margins to these components, that can be overridden with utility classes.

How to review

  • Check applicable components: Collapsible, Checkboxes with revealed input, Indented text.

@jrbarnes9 jrbarnes9 linked an issue Nov 5, 2021 that may be closed by this pull request
Consistent indented text/elements style of border #1657
Closed
@jrbarnes9 jrbarnes9 added the Enhancement Change of existing feature label Nov 5, 2021
@jrbarnes9 jrbarnes9 merged commit a73bb85 into master Nov 8, 2021
@jrbarnes9 jrbarnes9 deleted the 1657-consistent-indents branch November 8, 2021 11:33
boxadesign pushed a commit that referenced this pull request Feb 17, 2023
@jrbarnes9
Aligned styles of indented components (#1746)
cac9cd8 
* aligned styles of indented components

* percy issue fix

* more percy fixes [test-visual]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boxadesign boxadesign boxadesign approved these changes

@rmccar rmccar rmccar approved these changes

Assignees
No one assigned
Labels
Enhancement Change of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent indented text/elements style of border
3 participants
@jrbarnes9 @boxadesign @rmccar