Skip to content

Commit

Permalink
Aligned styles of indented components (#1746)
Browse files Browse the repository at this point in the history
* aligned styles of indented components

* percy issue fix

* more percy fixes [test-visual]
  • Loading branch information
jrbarnes9 authored Nov 8, 2021
1 parent cb0a909 commit a73bb85
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/components/checkboxes/_checkbox.scss
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ $checkbox-padding: 11px;
}

&__other {
border-left: 4px solid $color-grey-35;
border-left: 4px solid $color-borders-indent;
display: block;
margin: 0 1rem 0.5rem 1.1rem;
padding: 0 $checkbox-padding $checkbox-padding $checkbox-padding * 2 - 1;
Expand Down
6 changes: 5 additions & 1 deletion src/components/collapsible/_collapsible.scss
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,14 @@ $collapsible-caret-width: 1.5rem;
}

&__content {
border-left: 5px solid $color-grey-15;
border-left: 4px solid $color-borders-indent;
display: block;
margin: 1rem 0 0;
padding: 0 0 0 1.3em;

.ons-btn {
margin-bottom: 0.5rem;
}
}
}

Expand Down
3 changes: 2 additions & 1 deletion src/components/summary/examples/summary-grouped/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
},
{
"groupTitle": "Identity and health",
"headers":["Question", "Answer given"],
"rows": [
{
"rowTitle": "What is your country of birth?",
Expand Down Expand Up @@ -81,6 +82,7 @@
},
{
"groupTitle": "Qualifications",
"headers":["Question", "Answer given"],
"rows": [
{
"rowTitle": "Have you completed an apprenticeship?",
Expand Down Expand Up @@ -113,4 +115,3 @@
]
})
}}

4 changes: 2 additions & 2 deletions src/components/text-indent/_text-indent.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.ons-text-indent {
border-left: 5px solid $color-grey-35;
border-left: 4px solid $color-borders-indent;
margin: 0 0 1rem;
padding: 0 0 0 1em;
padding: 0 0 0 1.3em;
}
1 change: 1 addition & 0 deletions src/patterns/pages/hub-and-spoke/examples/hub/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ layout: none
{
"groups": [
{
"headers":["Name of section or person", "Section progress", "Access section"],
"rows": [
{
"rowTitle": "People who live here",
Expand Down
1 change: 1 addition & 0 deletions src/scss/vars/_colors.scss
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ $color-highlight: $color-neon-yellow !default;

// Borders
$color-borders: $color-grey-75 !default;
$color-borders-indent: $color-grey-35 !default;
$color-document-border: $color-grey-15 !default;
$color-document-border-focus: $color-black !default;

Expand Down

0 comments on commit a73bb85

Please sign in to comment.