Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent indented text/elements style of border #1657

Closed
jrbarnes9 opened this issue Aug 31, 2021 · 0 comments · Fixed by #1746
Closed

Consistent indented text/elements style of border #1657

jrbarnes9 opened this issue Aug 31, 2021 · 0 comments · Fixed by #1746
Labels
Component A component in the ONS Design System Enhancement Change of existing feature

Comments

@jrbarnes9
Copy link
Contributor

All indented text/elements should follow a consistent style of border

Includes:

  • onsTextIndent
  • onsCollapsible
  • Borderless onsRadios and onsCheckboxes with conditionally revealed input, select, checkboxes, radios

For the border colour, should we use the variable assigned to$color-borders or assign a lighter shade as a new variable?

Current onsTextIndent:

Screenshot 2021-08-24 at 16 39 04

Current onsCollapsible:

Screenshot 2021-08-24 at 16 39 08

Example of borderless onsRadios with conditionally revealed input:

Screenshot 2021-08-24 at 16 44 27

For an example of borderless onsCheckboxes with conditionally revealed checkboxes see #1648

Originally posted by @jrbarnes9 in #233 (comment)

@jrbarnes9 jrbarnes9 added Component A component in the ONS Design System Enhancement Change of existing feature labels Aug 31, 2021
@jrbarnes9 jrbarnes9 linked a pull request Nov 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component A component in the ONS Design System Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant