[Awaiting Payment April 30th] [$250] [Guided Setup] Update custom messages in the onboarding flow

[danielrvidal]

Coming from this design doc, in testing we found we were finding two welcome emails. One introing Concierge, and then one giving more info on the use case (details here).

As such, we'd like to update the message being triggered (the second message above) from the onboarding selection to remove the welcome portion of the subject line AND the concierge introduction currently in the message. As such, the messages that are based on use case selection are as follows:

If the user never makes a use case selection
We do not need to send anything, as we've already sent the intro.

If the user selects “I am just looking around”
We do not need to send anything, as we've already sent the intro and don't need more.

If the user selects “Chat and split expenses with friends”

# Splitting the bill is as easy as a conversation! 

To split an expense:
1. From the home screen, click the green + button > Request money.
2. Enter an amount or scan a receipt, then choose who you want to split it with.

We'll send a request to each person so they can pay you back. Let me know if you have any questions! 

If the user selects “Submit expenses to my employer to get paid back”

# Expensify is the fastest way to get paid back! 

To submit expenses for reimbursement:
1. From the home screen, click the green + button > Request money.
2. Enter an amount or scan a receipt, then input your boss's email.

That’ll send a request to get you paid back. Let me know if you have any questions! 

If the user selects “Track my business expenses to file taxes”

# Let’s start tracking your expenses! 

To track your expenses, create a workspace to keep everything in one place. Here’s how:
1. From the home screen, click the green + button > New Workspace
2. Give your workspace a name (e.g. "My business expenses”).

Then, add expenses to your workspace:
1. Find your workspace using the search field.
2. Click the gray + button next to the message field.
3. Click Request money, then add your expense type.

We’ll store all expenses in your new workspace for easy access. Let me know if you have any questions!

If the user selects “Manage my team’s expenses”

# Let’s start managing your team’s expenses! 

To manage your team's expenses, create a workspace to keep everything in one place. Here’s how:
1. From the home screen, click the green + button > New Workspace
2. Give your workspace a name (e.g. “Sales team expenses”).

Then, invite your team to your workspace via the Members pane and [connect a business bank account](https://help.expensify.com/articles/new-expensify/bank-accounts/Connect-a-Bank-Account) to reimburse them. Let me know if you have any questions!

If the user selects “Track and budget personal spend”

# Let’s start tracking your expenses! 

To track your expenses, create a workspace to keep everything in one place. Here’s how:
1. From the home screen, click the green + button > New Workspace
2. Give your workspace a name (e.g. "My expenses”).

Then, add expenses to your workspace:
1. Find your workspace using the search field.
2. Click the gray + button next to the message field.
3. Click Request money, then add your expense type.

We’ll store all expenses in your new workspace for easy access. Let me know if you have any questions!

Notes for completion:

• The # is just denoting using the custom subject line as already implemented.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0119f0ea9acc1824fb
• Upwork Job ID: 1780067887070625792
• Last Price Increase: 2024-04-16
• Automatic offers:
• jayeshmangwani | Reviewer | 0
• tienifr | Contributor | 0

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the customer messages for the onboarding flow

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

We need to remove the following welcome messages from all the const:

App/src/CONST.ts

Lines 3552 to 3560 in 5f04270

	[onboardingChoices.EMPLOYER]:
	'# Welcome to Expensify, the fastest way to get paid back!\n' +
	"Hi there, I'm Concierge. Chat with me here for anything you need.\n" +
	'\n' +
	'To submit expenses for reimbursement:\n' +
	'1. From the home screen, click the green + button > Request money.\n' +
	"2. Enter an amount or scan a receipt, then input your boss's email.\n" +
	'\n' +
	"That'll send a request to get you paid back. Let me know if you have any questions!",

So for example the above onboardingChoices.EMPLOYER will now be

[onboardingChoices.EMPLOYER]:

            'To submit expenses for reimbursement:\n' +
            '1. From the home screen, click the green + button > Request money.\n' +
            "2. Enter an amount or scan a receipt, then input your boss's email.\n" +
            '\n' +
            "That'll send a request to get you paid back. Let me know if you have any questions!",
            

This way we'll update all the messages from ONBOARDING_CONCIERGE:

App/src/CONST.ts

Line 3537 in 5f04270

ONBOARDING_CONCIERGE: {

These messages will be updated as per the description stated above in the issue

What alternative solutions did you explore? (Optional)

[allgandalf]

@danielrvidal , I guess you forgot to put the external and bug label here, similar issues are labeled external over here; #40154 thanks 🥂

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0119f0ea9acc1824fb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want to update custom messages in the onboarding flow

What is the root cause of that problem?

This is a new feature request.

What changes do you think we should make in order to solve the problem?

The list of Concierge welcome messages are here.

1. For onboardingChoices.TRACK, onboardingChoices.EMPLOYER, onboardingChoices.MANAGE_TEAM, onboardingChoices.PERSONAL_SPEND, onboardingChoices.CHAT_SPLIT

We need to update the custom message to remove Welcome to Expensify, part and also the Concierge introduction Hi there, I'm Concierge. Chat with me here for anything you need.. The use case CTA (eg. let's start tracking your expenses!) should be kept as header. (Note: We should not remove the welcome message as suggested in the above proposal)

So for onboardingChoices.TRACK, this part will become

"# Let’s start tracking your expenses!\n" +

Similar for other types listed above.

2. For onboardingChoices.LOOKING_AROUND here

We should remove the key and its usage completely since it's not needed.

So for onboardingChoices.LOOKING_AROUND (where the text here will be undefined, we'll not update the report and add the report action here)

What alternative solutions did you explore? (Optional)

NA

[allgandalf]

(Note: We should not remove the welcome message as suggested in the above proposal)

That is implementation detail @tienifr , for proposals we look at the basis idea of how the changes are going to be, thanks

Please refer the proposal completely, My proposal also stated the below:

These messages will be updated as per the description stated above in the issue

c.c. @jayeshmangwani

[tienifr]

These messages will be updated as per the description stated above in the issue

@GandalfGwaihir Isn't it the default thing that any proposal will have to do? 😄 So I'd think it doesn't add any extra value to your proposal.

Let's wait for the review from @jayeshmangwani 👍

[jayeshmangwani]

@GandalfGwaihir @tienifr Hey, I am carefully reviewing proposals, line by line. Please wait for a few minutes 🙏

[jayeshmangwani]

@GandalfGwaihir Question for you from your proposal,

So for example the above onboardingChoices.EMPLOYER will now be

[onboardingChoices.EMPLOYER]:
        'To submit expenses for reimbursement:\n' +
        '1. From the home screen, click the green + button > Request money.\n' +
        "2. Enter an amount or scan a receipt, then input your boss's email.\n" +
        '\n' +
        "That'll send a request to get you paid back. Let me know if you have any questions!",

You mentioned that onboardingChoices.EMPLOYER will now be like above, but this is missing the header part.

It should be below, right?

'# Expensify is the fastest way to get paid back! \n' +
'\n' +
'To submit expenses for reimbursement:\n' +
'1. From the home screen, click the green + button > Request money.\n' +
"2. Enter an amount or scan a receipt, then input your boss's email.\n" +
'\n' +
"That'll send a request to get you paid back. Let me know if you have any questions!",

[allgandalf]

It should be below, right?

Yes it should be and hence i mentioned at the end

These messages will be updated as per the description stated above in the issue

The proposal just contained an example edit of where the changes are going to be and not pin point texts :) I mean those are done during the PR stage right?

[jayeshmangwani]

The proposal just contained an example edit of where the changes are going to be and not pin point texts :) I mean those are done during the PR stage right?

Fair enough

[tienifr]

@jayeshmangwani @GandalfGwaihir The example should be correct and reflects the intention of the proposer, especially for straight-forward issues like this one.

The proposal here clearly says

We need to remove the following welcome messages from all the const:

So that's the intention, which is incorrect and doesn't solve the problem.

Also, in case of onboardingChoices.LOOKING_AROUND, the changes suggested by @GandalfGwaihir doesn't fix it.

[jayeshmangwani]

@GandalfGwaihir This is a pretty straightforward issue. There is a small missing detail in your proposal, though, that can be done on the PR process; for transparency, I find that @tienifr has a more accurate and detailed Proposal; we can go with them.

🎀 👀 🎀 C+ reviewed

It's kind of a little hard for me to decide, but let's see what internal engineer think of:

[melvin-bot]

Triggered auto assignment to @MariaHCD, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MariaHCD]

Thanks for the discussion here, everyone! In my opinion, if it's a straightforward issue, I'd be more likely to go with the more accurate and detailed proposal which, in this case, is @tienifr's proposal.

[melvin-bot]

📣 @jayeshmangwani 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[danielrvidal]

@tienifr given this is pretty straight forward, do you think your PR could be done today? This is just a high-priority issue, so I want to make sure to get a timeline with urgency. Thank you!

[allgandalf]

If they aren't available to work on this urgently, then I am available to work on this now ;) thanks

[danielrvidal]

Thank you @GandalfGwaihir, @tienifr if you can get the PR up by tomorrow, that would be great.

[tienifr]

Yes, PR will be up in 2 hours (it's pretty early in my timezone). Thanks for all the patience.

[tienifr]

PR ready for review #40328.

[jayeshmangwani]

Thanks for the PR, starting PR review

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

PR hit production a couple of days ago. Updating the title to reflect the payment hold and adding the bug label to assign a BZ... that happens to be me. :)

[MariaHCD]

Not overdue; on payment hold.

[melvin-bot]

@MariaHCD @trjExpensify @jayeshmangwani @tienifr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[trjExpensify]

Alright.. payment summary as follows:

• $250 to @tienifr for the bug fix
• $250 to @jayeshmangwani for the C+ review

Settled up with you both, closing!