Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hold for payment 2024-05-06] [$250] [Guided setup stage 1] Update message to include bold text #40154

Closed
1 of 6 tasks
MitchExpensify opened this issue Apr 11, 2024 · 26 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Apr 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.60-13
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: na
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: mitch@expensify.com
Slack conversation: Internal: https://expensify.slack.com/archives/C036QM0SLJK/p1712608278412419

Action Performed:

  1. Sign up to staging.new.expensify.com
  2. Go to staging.new.expensify.com/onboarding
  3. Enter first name and last name go, click "Continue" on the onboarding modal
  4. Click any option apart from "I'm just looking around"

Expected Result:

The message you receive in your Concierge DM should include some bold text:

If the user selects “Chat and split expenses with friends”:

Welcome to Expensify, where splitting the bill is an easy conversation!

Hi there, I’m Concierge. Chat with me here for anything you need.

To split an expense:

  1. From the home screen, click the green + button > Request money.
  2. Enter an amount or scan a receipt, then choose who you want to split it with.

We'll send a request to each person so they can pay you back. Let me know if you have any questions!

If the user selects “Submit expenses to my employer to get paid back”:

Welcome to Expensify, the fastest way to get paid back!

Hi there, I’m Concierge. Chat with me here for anything you need.

To submit expenses for reimbursement:
From the home screen, click the green + button > Request money.
Enter an amount or scan a receipt, then input your boss's email.

That’ll send a request to get you paid back. Let me know if you have any questions!

If the user selects “Track my business expenses to file taxes”

Welcome to Expensify, let’s start tracking your expenses!

Hi there, I’m Concierge. Chat with me here for anything you need.

To track your expenses, create a workspace to keep everything in one place. Here’s how:
From the home screen, click the green + button > New Workspace
Give your workspace a name (e.g. "My business expenses”).

Then, add expenses to your workspace:
Find your workspace using the search field.
Click the gray + button next to the message field.
Click Request money, then add your expense type.

We’ll store all expenses in your new workspace for easy access. Let me know if you have any questions!

If the user selects “Manage my team’s expenses”

Welcome to Expensify, let’s start managing your team’s expenses!

Hi there, I’m Concierge. Chat with me here for anything you need.

To manage your team's expenses, create a workspace to keep everything in one place. Here’s how:
From the home screen, click the green + button > New Workspace
Give your workspace a name (e.g. “Sales team expenses”).

Then, invite your team to your workspace via the Members pane and connect a business bank account to reimburse them. Let me know if you have any questions!

If the user selects “Track and budget personal spend”

Welcome to Expensify, let’s start tracking your expenses!

Hi there, I’m Concierge. Chat with me here for anything you need.

To track your expenses, create a workspace to keep everything in one place. Here’s how:
From the home screen, click the green + button > New Workspace
Give your workspace a name (e.g. "My expenses”).

Then, add expenses to your workspace:
Find your workspace using the search field.
Click the gray + button next to the message field.
Click Request money, then add your expense type.

We’ll store all expenses in your new workspace for easy access. Let me know if you have any questions!

Actual Result:

No bolded text

Workaround:

Continue regardless

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0187409a2437de19ab
  • Upwork Job ID: 1778885737882144768
  • Last Price Increase: 2024-04-15
  • Automatic offers:
    • nkdengineer | Contributor | 0
@MitchExpensify MitchExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@nkdengineer
Copy link
Contributor

nkdengineer commented Apr 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

  • Update message to include bold text

What is the root cause of that problem?

  • In here we do not have the bold markdown as mentioned in design.

What changes do you think we should make in order to solve the problem?

  • We should add the bold markdown to the text such as "Request money", "New Workspace", ...
  • For example, we can update this to:
            '1. From the home screen, click the green + button > *New Workspace*\n' +

What alternative solutions did you explore? (Optional)

  • NA

Result

image

@joekaufmanexpensify
Copy link
Contributor

@mountiny assigning you per this. LMK if I should instead make external and happy to do that.

@joekaufmanexpensify joekaufmanexpensify added the Internal Requires API changes or must be handled by Expensify staff label Apr 12, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0187409a2437de19ab

Copy link

melvin-bot bot commented Apr 12, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

@mountiny
Copy link
Contributor

Thanks, will have a look

@joekaufmanexpensify
Copy link
Contributor

TY!

@mountiny
Copy link
Contributor

on my list

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Apr 15, 2024
@melvin-bot melvin-bot bot changed the title [Guided setup stage 1] Update message to include bold text [$250] [Guided setup stage 1] Update message to include bold text Apr 15, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

@mountiny
Copy link
Contributor

@sobitneupane can you please review the proposals, its quite straightforwards, I think this can be external

@sobitneupane
Copy link
Contributor

Thanks for the proposal @nkdengineer

Your proposal looks good

🎀 👀 🎀 C+ reviewed

Copy link

melvin-bot bot commented Apr 16, 2024

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 16, 2024
@mountiny
Copy link
Contributor

@nkdengineer can you please make a PR for this? thanks

Copy link

melvin-bot bot commented Apr 16, 2024

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 18, 2024
@nkdengineer
Copy link
Contributor

@sobitneupane PR #40393 is ready

@skmanoj322
Copy link

Screenshot 2024-04-18 at 1 12 37 PM @nkdengineer just wanted to reproduce these but not able to get desire output but got these instead? is it because of the update?

Copy link

melvin-bot bot commented Apr 18, 2024

📣 @skmanoj322! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@skmanoj322
Copy link

Contributor details
Your Expensify account email:sk.manoj322@gmail.com
Upwork Profile Link:https://www.upwork.com/freelancers/~016dddddac7ac687d5

@joekaufmanexpensify
Copy link
Contributor

Automation was not working, payment is actually due now

@joekaufmanexpensify
Copy link
Contributor

We need to pay:

@joekaufmanexpensify joekaufmanexpensify changed the title [$250] [Guided setup stage 1] Update message to include bold text [hold for payment 2024-05-06] [$250] [Guided setup stage 1] Update message to include bold text May 6, 2024
@joekaufmanexpensify
Copy link
Contributor

@nkdengineer $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

@sobitneupane please request $250 and confirm here once complete

@sobitneupane
Copy link
Contributor

Requested payment on newDot.

@joekaufmanexpensify
Copy link
Contributor

TY!

@joekaufmanexpensify
Copy link
Contributor

Payment summary here. All set.

@JmillsExpensify
Copy link

$250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants