[HOLD for payment 2024-05-02] [Guided Setup] [$125] Minor copy modifications to Stage 1 onboarding

[anmurali]

Change the intent itself from I'm just looking around to Something else
Change the intent specific message to

# Welcome to Expensify! 

Hi there, I'm Concierge. Chat with me here for anything you need. 

Expensify is best known for expense and corporate card management, but we do a lot more than that. Let me know what you're interested in and I'll help get you started. 

cc @danielrvidal @zsgreenwald @quinthar

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f552ed32ec3ecab0
• Upwork Job ID: 1780786390866116608
• Last Price Increase: 2024-04-18
• Automatic offers:
• jjcoffee | Reviewer | 0
• GandalfGwaihir | Contributor | 0

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change the text in en.ts and es.ts files

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

We need to update the below message:

App/src/languages/en.ts

Line 1349 in 1a20e16

[CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: "I'm just looking around",

To

[CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: "Something else",

Same would be done with the Spanish file, we just need to translate it

We also need to add a intent message for LOOKING_AROUND, now over here the above stated intent message is wrong, we no longer welcome the user and show him the concierge message we should only display the last message part according to #40261, so we need to add the [onboardingChoices. LOOKING_AROUND] after here, So now the text would become:

[onboardingChoices. LOOKING_AROUND]:
            "Expensify is best known for expense and corporate card management, but we do a lot more than that. Let me know what you're interested in and I'll help get you started. ",

OR

[onboardingChoices. LOOKING_AROUND]:
            '# Expensify is best known for expense and corporate card management, but we do a lot more than that. Let me know what you're interested in and I'll help get you started.\n' ,

What alternative solutions did you explore? (Optional)

[allgandalf]

@anmurali , I guess you forgot to put the bug and external label :)

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f552ed32ec3ecab0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[sufyan-siddiqui]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change the intent message after onboarding from I'm just looking around to Something else

What is the root cause of that problem?

The message is defined as a constant variable CONST.ONBOARDING_CHOICES.LOOKING_AROUND in the language specific constant files. For English its in

App/src/languages/en.ts

App/src/languages/en.ts

Line 1330 in 3ec8f2f

[CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: "I'm just looking around",

And the for Spanish its in

App/src/languages/en.ts

App/src/languages/es.ts

Line 1329 in 3ec8f2f

[CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: 'Sólo estoy mirando',

What changes do you think we should make in order to solve the problem?

For the quick fix for just the message only, we can change the constant CONST.ONBOARDING_CHOICES.LOOKING_AROUND in the en.ts file to Something else and in the es.ts file to Otra cosa or any appropriate translation in this case.

What alternative solutions did you explore? (Optional)

Since the constants were defined with the message I'm just looking around in mind, so they're named LOOKING_AROUND as well. For further enhancement, the constant names should also be updated to SOMETHING_ELSE. Consequently. there references in the below files should be updated.

src/CONST.ts

src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Another update would be the Icon. Currently the Binoculars icon is assigned to the choice because it made more sense given the looking around message. The icon should be updated to any appropriate icon that relates well with the choice "Something else" in the below line

App/src/pages/OnboardingPurpose/BaseOnboardingPurpose.tsx

Line 39 in 3ec8f2f

[CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: Illustrations.Binoculars,

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Minor copy modifications to Stage 1 onboarding

What is the root cause of that problem?

This is a new requirement

What changes do you think we should make in order to solve the problem?

There're 2 changes we need to make:

1. Update the text here

   App/src/languages/en.ts

   Line 1330 in 3ec8f2f

   [CONST.ONBOARDING_CHOICES.LOOKING_AROUND]: "I'm just looking around",

   
   to Something else, and also the Spanish version

We should also update the key to CONST.ONBOARDING_CHOICES.SOMETHING_ELSE

2. The other requirement is Change the intent specific message, for which we need to add a new key here for onboardingChoices.LOOKING_AROUND, with the text specified in the OP

# Welcome to Expensify! 

Hi there, I'm Concierge. Chat with me here for anything you need. 

Expensify is best known for expense and corporate card management, but we do a lot more than that. Let me know what you're interested in and I'll help get you started. 

We'll use string concatenation like we did with messages for other use case here

Then it will be automatically applied because we're adding the text based on selectedPurpose as in here

Also the object key should also be changed to SOMETHING_ELSE

This is more like the design and product team's opinion, but we can have a different intent message (from the OP) that's consistent with other use cases. If we look at other use cases like here, we can see that it has a format of:

# Use case header

More explanation

If we want to be consistent for something else use case, we can have a message like

# Expensify can help you in multiple use cases!

Expensify is best known for expense and corporate card management, but we do a lot more than that. Let me know what you're interested in and I'll help get you started. 

What alternative solutions did you explore? (Optional)

NA

[allgandalf]

Updated proposal:

Updated proposal, the text in the OP is wrong, according to #40261, we should not show the welcome and concierge message for onboardingChoices, have added the same explanation in my proposal along with 2 options in text. c.c. @jjcoffee

[nkdengineer]

Proposal updated to add suggestion for the intent message to be consistent with other use cases.

@jjcoffee Just a small note that my proposal is the first one that gets it working according to the OP description, in case we want to change the OP, like the intent message, it's just a small text change that can be addressed in the PR phase.

[jjcoffee]

Thanks for the proposals, everyone! As this is a very small issue, getting the proposal details right is what matters the most. It looks like @GandalfGwaihir was the first to get extra detail regarding the correct text to add to the onBordingChoices, so I think we can go with their proposal.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rlinoz]

Sounds good, assigning @GandalfGwaihir

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

PR ready for review @jjcoffee , waiting for Spanish translation

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change the intent for Looking Around Onboarding Flow #40667

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @GandalfGwaihir requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[abekkala]

PAYMENT SUMMARY:

• FIX: @GandalfGwaihir [$125] payment sent and contract ended - thank you 🎉
• PR REVIEW: @jjcoffee [$125] payment sent and contract ended - thank you 🎉