Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect plugin name #6077

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix: incorrect plugin name #6077

merged 1 commit into from
Apr 13, 2022

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes MF-434

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions
Copy link
Contributor

🚀 Deployed on https://62569e8d37f101706ac7a15d--compassionate-northcutt-326a3a.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 13, 2022 09:57 Inactive
@guanbinrui guanbinrui merged commit b4b66c8 into develop Apr 13, 2022
@guanbinrui guanbinrui deleted the fix/incorrect-name branch April 13, 2022 14:59
yanzhihong23 added a commit that referenced this pull request Apr 18, 2022
@yanzhihong23
Merge branch 'develop' into fix-ito-icon
dc0f6b3 
* develop:
  refactor: move backup code to backup-format package (#5922)
  fix: incorrect text (#6096)
  chore: change iOS idb fix
  chore: improve code style (#6090)
  refactor: cleanup code and add deprecations
  refactor: cleanup code
  feat: add transaction dialog in saving plugin (#6076)
  refactor: cleanup code
  refactor: cleanup post context (#6089)
  feat: add ECKeyIdentifier.publicKeyAsHex close GH-6082 (#6085)
  refactor: avoid prop drilling (#6083)
  chore: setup i18n in background (#6086)
  chore: improve eslint (#6084)
  fix: sprint2 ui issues  (#6042)
  refactor: rename createSubscriptionFromValueRef
  chore: update plugin template
  fix: incorrect plugin name (#6077)
@guanbinrui guanbinrui mentioned this pull request Apr 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UncleBill UncleBill UncleBill approved these changes

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
Test: Pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuanyang233 @UncleBill @guanbinrui