-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sprint2 ui issues #6042
fix: sprint2 ui issues #6042
Conversation
anchorOrigin: { | ||
vertical: 'top', | ||
horizontal: 'left', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same problem when developed the tip feature.
I think no need to catch the container via usePortalShadowRoot
and do prop drilling.
instead of
Maskbook/packages/mask/src/plugins/RedPacket/SNSAdaptor/RedPacketDialog.tsx
Lines 247 to 255 in e46d955
children: usePortalShadowRoot((container) => ( | |
<RedPacketCreateNew | |
origin={settings} | |
onNext={onNext} | |
state={tokenState} | |
onClose={onClose} | |
onChange={onChange} | |
SelectMenuProps={{ container }} | |
/> |
suggest
Maskbook/packages/mask/src/plugins/NextID/components/Tip/TipForm.tsx
Lines 128 to 146 in e46d955
<Select | |
className={classes.address} | |
ref={selectRef} | |
value={recipient} | |
disabled={isSending} | |
onChange={(e) => { | |
setRecipient(e.target.value) | |
}} | |
MenuProps={{ | |
anchorOrigin: { | |
vertical: 'bottom', | |
horizontal: 'center', | |
}, | |
container: selectRef.current, | |
anchorEl: selectRef.current, | |
BackdropProps: { | |
invisible: true, | |
}, | |
}}> |
* develop: refactor: move backup code to backup-format package (#5922) fix: incorrect text (#6096) chore: change iOS idb fix chore: improve code style (#6090) refactor: cleanup code and add deprecations refactor: cleanup code feat: add transaction dialog in saving plugin (#6076) refactor: cleanup code refactor: cleanup post context (#6089) feat: add ECKeyIdentifier.publicKeyAsHex close GH-6082 (#6085) refactor: avoid prop drilling (#6083) chore: setup i18n in background (#6086) chore: improve eslint (#6084) fix: sprint2 ui issues (#6042) refactor: rename createSubscriptionFromValueRef chore: update plugin template fix: incorrect plugin name (#6077)
Description
Closes #MF-27 #MF-269
Type of change
Previews
Checklist
console.log
sIf this PR depends on external APIs:
chrome-extension://[id]
moz-extension://[id]