Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sprint2 ui issues #6042

Merged
merged 6 commits into from
Apr 14, 2022
Merged

fix: sprint2 ui issues #6042

merged 6 commits into from
Apr 14, 2022

Conversation

BillySh1
Copy link
Contributor

@BillySh1 BillySh1 commented Apr 7, 2022

Description

Closes #MF-27 #MF-269

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

@github-actions github-actions bot temporarily deployed to pull request April 7, 2022 10:14 Inactive
guanbinrui
guanbinrui previously approved these changes Apr 7, 2022
Jack-Works
Jack-Works previously approved these changes Apr 8, 2022
anchorOrigin: {
vertical: 'top',
horizontal: 'left',
},
Copy link
Contributor

@UncleBill UncleBill Apr 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same problem when developed the tip feature.

I think no need to catch the container via usePortalShadowRoot and do prop drilling.

instead of

children: usePortalShadowRoot((container) => (
<RedPacketCreateNew
origin={settings}
onNext={onNext}
state={tokenState}
onClose={onClose}
onChange={onChange}
SelectMenuProps={{ container }}
/>

suggest

<Select
className={classes.address}
ref={selectRef}
value={recipient}
disabled={isSending}
onChange={(e) => {
setRecipient(e.target.value)
}}
MenuProps={{
anchorOrigin: {
vertical: 'bottom',
horizontal: 'center',
},
container: selectRef.current,
anchorEl: selectRef.current,
BackdropProps: {
invisible: true,
},
}}>

@BillySh1 BillySh1 dismissed stale reviews from Jack-Works and guanbinrui via e0d7e43 April 12, 2022 06:07
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 06:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 06:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 06:35 Inactive
guanbinrui
guanbinrui previously approved these changes Apr 12, 2022
@github-actions github-actions bot temporarily deployed to pull request April 12, 2022 17:45 Inactive
@guanbinrui guanbinrui merged commit 6286466 into develop Apr 14, 2022
@guanbinrui guanbinrui deleted the fix/sprint2-issues branch April 14, 2022 07:09
yanzhihong23 added a commit that referenced this pull request Apr 18, 2022
* develop:
  refactor: move backup code to backup-format package (#5922)
  fix: incorrect text (#6096)
  chore: change iOS idb fix
  chore: improve code style (#6090)
  refactor: cleanup code and add deprecations
  refactor: cleanup code
  feat: add transaction dialog in saving plugin (#6076)
  refactor: cleanup code
  refactor: cleanup post context (#6089)
  feat: add ECKeyIdentifier.publicKeyAsHex close GH-6082 (#6085)
  refactor: avoid prop drilling (#6083)
  chore: setup i18n in background (#6086)
  chore: improve eslint (#6084)
  fix: sprint2 ui issues  (#6042)
  refactor: rename createSubscriptionFromValueRef
  chore: update plugin template
  fix: incorrect plugin name (#6077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants