Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve eslint #6084

Merged
merged 3 commits into from
Apr 14, 2022
Merged

chore: improve eslint #6084

merged 3 commits into from
Apr 14, 2022

Conversation

septs
Copy link
Contributor

@septs septs commented Apr 14, 2022

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2022 •
edited
Loading

🚀 Deployed on https://6257f5e667ce3d6cb443a195--compassionate-northcutt-326a3a.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 14, 2022 10:04 Inactive
@septs septs requested review from Jack-Works and guanbinrui April 14, 2022 10:09
@github-actions github-actions bot temporarily deployed to pull request April 14, 2022 10:22 Inactive
@Jack-Works Jack-Works merged commit fd79d1b into develop Apr 14, 2022
@Jack-Works Jack-Works deleted the septs/improve-eslint branch April 14, 2022 10:29
nuanyang233 pushed a commit that referenced this pull request Apr 14, 2022
@septs @nuanyang233
chore: improve eslint (#6084)
4e3d5db 
* chore: improve eslint

* revert: file

* fix: eslintrc
yanzhihong23 added a commit that referenced this pull request Apr 18, 2022
@yanzhihong23
Merge branch 'develop' into fix-ito-icon
dc0f6b3 
* develop:
  refactor: move backup code to backup-format package (#5922)
  fix: incorrect text (#6096)
  chore: change iOS idb fix
  chore: improve code style (#6090)
  refactor: cleanup code and add deprecations
  refactor: cleanup code
  feat: add transaction dialog in saving plugin (#6076)
  refactor: cleanup code
  refactor: cleanup post context (#6089)
  feat: add ECKeyIdentifier.publicKeyAsHex close GH-6082 (#6085)
  refactor: avoid prop drilling (#6083)
  chore: setup i18n in background (#6086)
  chore: improve eslint (#6084)
  fix: sprint2 ui issues  (#6042)
  refactor: rename createSubscriptionFromValueRef
  chore: update plugin template
  fix: incorrect plugin name (#6077)
guanbinrui added a commit that referenced this pull request Apr 20, 2022
@nuanyang233 @BillySh1
@guanbinrui @septs @Jack-Works @zhouhanseng
feat: improve mask popup (#5986)
e8aac37 
* feat: upgrade mask wallet setting page

* feat: popup bottom navigator

* feat: new header for popup

* fix: adjust header for ssr

* fix: build error

* fix: prettier

* refactor: split smart and dumb component

* fix: bugfix

* fix: icon

* fix: bugfix

* fix: bugfix

* feat: new persona page

* fix: bugfix

* fix: bugfix

* fix: bugfix

* fix: network icon

* fix: bugfix

* fix: bugfix for header

* fix: build error

* feat: popup nextid (#6028)

* feat: compo steps init

* fix: ui

* fix: fix

* fix: kill unused code

* feat: slient sign

* fix: fix

* fix: fix

* feat: connect wallet page

* fix: typo

* fix: typo

* fix: comment

* refactor: temp

* refactor: refact steps compo

* fix: fix

Co-authored-by: nuanyang233 <nuanyang233@gmail.com>

* feat: connect wallet with persona

* feat: connect popup wallet (#6081)

* feat: impl the connect page

* refactor: replace mm logo

* fix: bugfix

* fix: bugfix

* fix: reply to commnts

* fix: typo

* fix: typo again

* chore: improve eslint (#6084)

* chore: improve eslint

* revert: file

* fix: eslintrc

* chore: setup i18n in background (#6086)

* fix: revert remove i18n key

* fix: remove wallet sign

* fix: temp

* feat: popup connect wallet (#6088)

* fix: personalSign

* refactor: replace NetworkType with ChainId

* fix: popup connect wallet

* fix: bugfix

* feat: popup custom snackbar

* fix: eslint

* fix: fix

* fix: delete unused code

* fix: ui

* refactor: move verify wallet to persona

* fix: navigate replace

* fix: ui issues

* fix: refresh proofs when bound

* chore: ui style

* fix: persona max length

* fix: persona max length

* chore: reply review

* fix: i18n init twice in wrong context

* feat: add loading at connected wallets page

* fix: reply to coments

* fix: locales

* fix: disable open new window when sign on popup

* fix: pos

* fix: replace

* fix: steps btn loading

* fix: navigate back when wallet sign success

* refactor: replace useState to useAsyncFn

* fix: adjust connect wallet step

* fix: err state

* fix: go back when wallet signed

* fix: bugfix

* fix:  wallet name

* feat: add ECKeyIdentifier.publicKeyAsHex close GH-6082 (#6085)

* refactor: cleanup post context (#6089)

* refactor: cleanup code

* feat: add transaction dialog in saving plugin (#6076)

* feat: add transaction dialog in saving plugin

* fix: bugfix

* fix: reset state when transaction has been confirmed

* refactor: cleanup code

* refactor: cleanup code and add deprecations

* chore: improve code style (#6090)

* chore: change iOS idb fix

* fix: incorrect text (#6096)

* refactor: move backup code to backup-format package (#5922)

* refactor: move backup code to backup-format package

* wip

* feat: impl generate backup

* refactor: rename file

* store

* refactor: impl addUnconfirmedBackup

* refactor: impl getUnconfirmedBackup

* refactor: impl restoreUnconfirmedBackup

* refactor: impl all wrapper

* refactor: impl post restore

* refactor: impl wallet and plugin restore

* refactor: move unused file

* chore: misc

* chore: misc

* chore: misc

* fix: bugs

* fix: type error

* chore: remove one alias

* chore: remove unused string

* fix: lockfile

* fix: type error

* fix: two bugs

* fix: lucky drop schema (#6093)

* chore: lucky drop schema

* chore: lucky drop schema

* chore: reply code review

* fix: incorrect contracts query on dashboard (#6095)

* refactor: move some functions

* refactor: move detachProfileWithNextID

* refactor: move queryPersonaByPrivateKey

* refactor: move resolveUnknownLegacyIdentity

* refactor: move relation methods

* refactor: move attach/detach profile

* refactor: move mobile_restoreFromMnemonicWords

* refactor: move downloadBackup

* refactor: move createPersonaByMnemonic

* refactor: move openDashboard

* refactor: rename WelcomeService to BackupService

* fix: bugfix

* chore: reply review

* fix: reply

* chore: improve network icon at select wallet page

* fix: sign request with verify wallet

* fix: bugfix

* fix: bugfix

* fix: code review (#6105)

* fix: hash router

* fix: select wallet

* fix: sign with non-default wallet

* chore: i18n

* fix: lint error

Co-authored-by: BillyS <Billy@mask.io>
Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Co-authored-by: septs <github@septs.pw>
Co-authored-by: Jack Works <jackworks@protonmail.com>
Co-authored-by: Hancheng Zhou <z308114274@gmail.com>
Co-authored-by: guanbinrui <guanbinrui@dimension.im>
BillySh1 added a commit that referenced this pull request Apr 24, 2022
@BillySh1 @nuanyang233
@guanbinrui @septs @Jack-Works @zhouhanseng @UncleBill
feat: tips entrance (#6012)
6c6b28f 
* feat: upgrade mask wallet setting page

* feat: tips enterence init

* feat: dialog

* feat: injected dialog suppose actions badge

* feat: temp

* feat: tips wallet ui

* fix: fix

* fix: temp

* feat: popup bottom navigator

* feat: new header for popup

* fix: adjust header for ssr

* fix: build error

* fix: prettier

* refactor: split smart and dumb component

* fix: bugfix

* fix: icon

* feat: bodyviews

* fix: sth wrong

* fix: fix sth

* feat: ui

* fix: bugfix

* fix: fix

* fix: default ui

* fix: bugfix

* feat: new persona page

* fix: bugfix

* fix: bugfix

* fix: bugfix

* fix: network icon

* fix: bugfix

* fix: bugfix for header

* fix: build error

* feat: popup nextid (#6028)

* feat: compo steps init

* fix: ui

* fix: fix

* fix: kill unused code

* feat: slient sign

* fix: fix

* fix: fix

* feat: connect wallet page

* fix: typo

* fix: typo

* fix: comment

* refactor: temp

* refactor: refact steps compo

* fix: fix

Co-authored-by: nuanyang233 <nuanyang233@gmail.com>

* feat: connect wallet with persona

* fix: empty com

* fix: wallet list

* fix: wallet interface

* feat: connect popup wallet (#6081)

* feat: impl the connect page

* refactor: replace mm logo

* fix: kv temp

* fix: bugfix

* fix: bugfix

* fix: reply to commnts

* fix: typo

* fix: typo again

* chore: improve eslint (#6084)

* chore: improve eslint

* revert: file

* fix: eslintrc

* chore: setup i18n in background (#6086)

* fix: revert remove i18n key

* fix: remove wallet sign

* fix: temp

* feat: popup connect wallet (#6088)

* fix: personalSign

* refactor: replace NetworkType with ChainId

* fix: popup connect wallet

* fix: bugfix

* feat: popup custom snackbar

* fix: eslint

* fix: fix

* fix: delete unused code

* fix: ui

* refactor: move verify wallet to persona

* fix: navigate replace

* fix: ui issues

* fix: refresh proofs when bound

* fix: conflict

* fix: fix

* Delete settings.json

* fix: vscode settings

* fix: temp

* fix: types

* fix: wallet dialog

* fix: set as default

* fix: typo

* fix: sth

* feat: switch

* feat: disconnect dialog

* fix: disconnect

* chore: ui style

* fix: persona max length

* fix: fix

* fix: persona max length

* chore: reply review

* fix: i18n init twice in wrong context

* feat: add loading at connected wallets page

* fix: temp

* fix: reply to coments

* fix: locales

* fix: kill !evm

* fix: disable open new window when sign on popup

* fix: pos

* fix: replace

* fix: steps btn loading

* fix: navigate back when wallet sign success

* refactor: replace useState to useAsyncFn

* fix: adjust connect wallet step

* fix: err state

* fix: go back when wallet signed

* fix: temp

* fix: ui

* fix:  wallet name

* fix: bugfix

* fix: sign

* fix: sign step

* fix: fix

* fix: sth

* fix: fix

* chore: tips no wallet connected required

* fix: fix bug

* chore: tips jump to next id

* fix: fix

* fix: sign text

* fix: ens

* fix: disable when not in evm

* fix: ui temp

* fix: temp

* fix: ui

* fix: empty status

* fix: fix address crash

* fix: add && del fix

* fix: confirm bug

* fix: fix

* fix: some ui issues

* fix: change icon

* fix: temp

* fix: icon

* fix: del wlt&& un unsed code

* fix: kv storage

* fix: reply temp

* fix: temp

* fix: fix

* style: judge

* fix: lint err

* fix: verify

* feat: only evm

* fix: only evm fix

* fix: sth

* fix: sort

* style: kill console

* fix: kv

* fix: lint

* fix: sort fix

* chore: disable tips entry as no nextId

* style: debug

* fix: kill prividerdespecter

* chore: remove useless interface

* fix: fix

* fix: kill unused type

* fix: discard unrelated changes

* chore: add config

* fix: wallet name idx

* fix: reverse

* fix: steps wallet name

* fix: wallet name sign fix

* style: reply

* fix: new idx

* fix: wallet name sort

* fix: typo

* fix: optimise change default speed

* fix: locales

* chore: handle sns persona unmatched

* chore: move verify logic out of tips

* chore: rename

* style: reply to cmt

* Update packages/mask/src/plugins/Tips/SNSAdaptor/TipsEntranceDialog.tsx

Co-authored-by: UncleBill <billbill290@gmail.com>

* fix: for review

* fix: name

* chore: reply code review

* fix: typo

* fix: name fix

* style: reply to comments

* Update packages/shared-base/src/NextID/type.ts

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>

* fix: resolve issues

* Update packages/mask/src/components/shared/ApplicationBoard.tsx

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>

* fix: review

* fix: types

* fix: reply

* fix: reply

* fix(tips): some improvement (#6129)

* fix: fix

* style: reply to comments

* refactor: refact the useTipsWalletsList

* fix: build

* fix: types

* fix: build empty component

* chore: reply code review

* chore: reply code review

Co-authored-by: nuanyang233 <nuanyang233@gmail.com>
Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Co-authored-by: septs <github@septs.pw>
Co-authored-by: Jack Works <jackworks@protonmail.com>
Co-authored-by: zhouhanseng <z308114274@gmail.com>
Co-authored-by: UncleBill <billbill290@gmail.com>
@guanbinrui guanbinrui mentioned this pull request Apr 24, 2022
Merged
@Jsn2win Jsn2win mentioned this pull request Nov 28, 2023
Open
This was referenced Mar 22, 2024
Open
Open
@yisiliu yisiliu mentioned this pull request Mar 24, 2024
Closed
@yisiliu yisiliu mentioned this pull request Apr 18, 2024
Closed
This was referenced Oct 16, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works approved these changes

@guanbinrui guanbinrui Awaiting requested review from guanbinrui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@septs @Jack-Works