Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing opens new tab instead of popup since 4.7 #6640

Closed
aheckler opened this issue Mar 13, 2017 · 0 comments
Closed

Sharing opens new tab instead of popup since 4.7 #6640

aheckler opened this issue Mar 13, 2017 · 0 comments
Assignees
@jeherve
Labels
[Feature] Sharing Post sharing, sharing buttons [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Milestone
4.7.1

Comments

@aheckler
Copy link
Member

aheckler commented Mar 13, 2017 •
edited
Loading

To repro:

  1. Install and activate 4.6.
  2. Enable Sharing module with the Facebook button.
  3. Go to a post.
  4. Share it. FB share popup opens.
  5. Upgrade to 4.7.
  6. Go back to post.
  7. Share it using FB button.

What happens: a whole new tab opens for the sharing thing.

What I expected: a much smaller popup window.

3101777-t
@aheckler aheckler added [Feature] Sharing Post sharing, sharing buttons [Pri] High [Type] Bug When a feature is broken and / or not performing as intended labels Mar 13, 2017
jeherve added a commit that referenced this issue Mar 13, 2017
@jeherve
Sharing: revert changes to echo inline sharing js
c3449bd 
Fixes #6640
Reverts changes introduced in #6339

`$service->display_footer()` includes calls to `js_dialog` when not using Jetpack's Official sharing buttons.
`js_dialog` often uses `wp_add_inline_script()`, thus recreating the issues described in #6640.
@jeherve jeherve mentioned this issue Mar 13, 2017
Closed
@jeherve jeherve self-assigned this Mar 13, 2017
@jeherve jeherve added this to the 4.7.1 milestone Mar 13, 2017
@zinigor zinigor mentioned this issue Mar 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] Sharing Post sharing, sharing buttons [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
4.7.1
Development

No branches or pull requests
2 participants
@jeherve @aheckler