Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction to string "Simple Payments" #10190

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Correction to string "Simple Payments" #10190

merged 1 commit into from
Sep 21, 2018

Conversation

wigglemuff
Copy link
Contributor

@wigglemuff wigglemuff commented Sep 20, 2018 •
edited by jeherve
Loading

Changes proposed in this Pull Request:

Note: This is my first PR in this repo so please let me know about my mistakes and how I can improve them. From what I understand, this should be pretty straight forward as it involves string correction.

@wigglemuff wigglemuff requested a review from a team as a code owner September 20, 2018 22:53
@jetpackbot
Copy link
Collaborator

Warnings
⚠️

"Testing instructions" are missing for this PR. Please add some
⚠️

"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@wigglemuff wigglemuff mentioned this pull request Sep 20, 2018
Closed
@wigglemuff
Copy link
Contributor Author

If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so.

I think so because the original issue explains it very well and this patch should fix all strings in here:

Inconsistent strings within the plugin:
https://translate.wordpress.org/projects/wp-plugins/jetpack/dev/ja/default?filters%5Bterm%5D=simple+payment+&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. Simple Payments and removed [Status] In Progress labels Sep 21, 2018
@jeherve jeherve requested a review from rodrigoi September 21, 2018 06:06
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 21, 2018
@jeherve jeherve added this to the 6.6 milestone Sep 21, 2018
jeherve
jeherve approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 🚢

@jeherve
Copy link
Member

jeherve commented Sep 21, 2018

Nice first contribution :)

Quick note for your next PRs: don't forget the testing instructions. :)

@kraftbj kraftbj merged commit e094eeb into Automattic:master Sep 21, 2018
@kraftbj
Copy link
Contributor

kraftbj commented Sep 21, 2018

I believe this should be syncing back to WP.com, but looks like SImple Payments may not be in the build script. I'll check that out shortly.

@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 21, 2018
@kraftbj kraftbj self-assigned this Sep 21, 2018
@wigglemuff wigglemuff deleted the fix/simple-payments-make-name-consistent branch September 21, 2018 15:37
@kraftbj
Copy link
Contributor

kraftbj commented Sep 21, 2018

Added to Fusion and brought downstream changes up in D18702-code

jeherve added a commit that referenced this pull request Sep 24, 2018
@jeherve
changelog: add #10190
f645f6c
jeherve added a commit that referenced this pull request Sep 25, 2018
@jeherve
Changelog for 6.6 release (#10107)
581489a 
* Readme: add boilerplate for next release, 6.6

* Add 6.5 to the changelog.txt file

* Set boilerplate testing list for 6.6

* Readme: update stable tag to 6.5

* Add bullets to 6.5 changelog items

* Readme: add link to previous changelogs

This will help folks who want to know more about past releases,
while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release.

* Changelog: add information at the top of the changelog file.

* Changelog: add #10054

* Changelog: add #10078

* Changelog: add #10079

* Changelog: add #10064

* Changelog: add #10094

* Changelog: add #10096

* Testing list: add more information based on #10087

* Changelog: add #9847

* Changelog: add #10084

* Changelog: add #9918

* Changelog: add #7614

* Changelog: add #10116

* Changelog: add #10108

* Changelog: add #10041

* Changelog: add #10121

* Changelog: add #10134

* Changelog: add #10130

* Changelog: add #10109

* changelog: add #10137

* changelog: add #9952

* changelog: add #10120

* changelog: add #10162

* Changelog: add #10163

* Changelog: add #10092

* changelog: add #10156

* Changelog: add #10154

* changelog: add #10122

* Changelog: add #10101

* changelog: add #10105

* changelog: add #10190

* Changelog: add #10196

* changelog: add #10152

* Changelog: add #10153

* Testing list: add more details to Site Verification testing steps.

@see #10143 (comment)

* changelog: add #10194

* Changelog: add #10193
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@rodrigoi rodrigoi Awaiting requested review from rodrigoi

Assignees

@kraftbj kraftbj

@wigglemuff wigglemuff

Labels
[Feature] Pay with PayPal aka Simple Payments [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.6
Development

Successfully merging this pull request may close these issues.
5 participants
@wigglemuff @jetpackbot @jeherve @kraftbj @matticbot