Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: send gutenberg info when syncing posts #10130

Merged
merged 3 commits into from
Sep 13, 2018
Merged

Sync: send gutenberg info when syncing posts #10130

merged 3 commits into from
Sep 13, 2018

Conversation

roccotripaldi
Copy link
Member

@roccotripaldi roccotripaldi commented Sep 11, 2018 •
edited
Loading

This PR, specifically will detect if a post is being saved via Gutenberg's 2-request-post-saving mechanism, which sends 1 request to save the post, and one request to save stuff related to meta boxes.

The aim is to prevent from double-syncing stuff upstream, causing an issue where 2 events appear in the activity log.

To test:

  • Apply this PR to a test site
  • Publish and Update posts using the gutenberg editor, and with the classic editor
  • Observe the sync data flowing up-stream
  • Does is_gutenberg_meta_box_update appear as expected?

Before merging:

  • Test and merge up-stream equivalent: D18168-code

@roccotripaldi roccotripaldi requested a review from a team September 11, 2018 18:31
@roccotripaldi roccotripaldi requested a review from a team as a code owner September 11, 2018 18:31
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D18168-code. (newly created revision)

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D18168-code. (updated diff)

@jetpackbot
Copy link
Collaborator

Warnings
⚠️

"Testing instructions" are missing for this PR. Please add some
⚠️

"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D18168-code. (updated diff)

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D18168-code. (updated diff)

@roccotripaldi
Copy link
Member Author

Thanks @simison - that's helpful!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 12, 2018
jeherve
jeherve approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well on my end! 👍

@roccotripaldi
Copy link
Member Author

Upstream has been tested and merged: r-180577-wpcom

@brbrr brbrr added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Sep 13, 2018
@roccotripaldi roccotripaldi merged commit d9bdecb into master Sep 13, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 13, 2018
@roccotripaldi roccotripaldi mentioned this pull request Sep 13, 2018
Closed
@jeherve jeherve deleted the update/sync-post-for-gutenberg branch September 14, 2018 09:00
jeherve added a commit that referenced this pull request Sep 14, 2018
@jeherve
Changelog: add #10130
f18736b
@jeherve jeherve added this to the 6.6 milestone Sep 14, 2018
jeherve added a commit that referenced this pull request Sep 24, 2018
@jeherve
Changelog: add #10130
549db32
jeherve added a commit that referenced this pull request Sep 25, 2018
@jeherve
Changelog for 6.6 release (#10107)
581489a 
* Readme: add boilerplate for next release, 6.6

* Add 6.5 to the changelog.txt file

* Set boilerplate testing list for 6.6

* Readme: update stable tag to 6.5

* Add bullets to 6.5 changelog items

* Readme: add link to previous changelogs

This will help folks who want to know more about past releases,
while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release.

* Changelog: add information at the top of the changelog file.

* Changelog: add #10054

* Changelog: add #10078

* Changelog: add #10079

* Changelog: add #10064

* Changelog: add #10094

* Changelog: add #10096

* Testing list: add more information based on #10087

* Changelog: add #9847

* Changelog: add #10084

* Changelog: add #9918

* Changelog: add #7614

* Changelog: add #10116

* Changelog: add #10108

* Changelog: add #10041

* Changelog: add #10121

* Changelog: add #10134

* Changelog: add #10130

* Changelog: add #10109

* changelog: add #10137

* changelog: add #9952

* changelog: add #10120

* changelog: add #10162

* Changelog: add #10163

* Changelog: add #10092

* changelog: add #10156

* Changelog: add #10154

* changelog: add #10122

* Changelog: add #10101

* changelog: add #10105

* changelog: add #10190

* Changelog: add #10196

* changelog: add #10152

* Changelog: add #10153

* Testing list: add more details to Site Verification testing steps.

@see #10143 (comment)

* changelog: add #10194

* Changelog: add #10193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@gititon gititon gititon approved these changes

Assignees
No one assigned
Labels
[Feature] Activity Log [Package] Sync [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.6
Development

Successfully merging this pull request may close these issues.
7 participants
@roccotripaldi @matticbot @jetpackbot @simison @jeherve @gititon @brbrr