Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masterbar: Add the activity link to the master bar #10064

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

enejb
Copy link
Member

@enejb enejb commented Aug 28, 2018

In Automattic/wp-calypso#26941 we are adding the activity log to the sidebar.

This PR adds the activity log to the master bar.

This is the complimentary .com pr D17682-code

screen_shot_2018-09-04_at_10_49_42_am

Changes proposed in this Pull Request:

  • Add the activity link to the master bar

Testing instructions:

  • Activate the Master bar to your site.
  • Manual testing: Does the activity log link work as expected?

Proposed changelog entry for your changes:

Add the activity link to the master bar

@enejb enejb requested a review from a team as a code owner August 28, 2018 23:15
@enejb enejb requested a review from roccotripaldi August 28, 2018 23:15
@enejb enejb added [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Activity Log labels Aug 28, 2018
@enejb enejb added this to the 6.5 milestone Aug 28, 2018
@jetpackbot
Copy link
Collaborator

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@oskosk oskosk modified the milestones: 6.5, 6.6 Aug 30, 2018
Copy link
Member

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, but i'm not seeing the icon for 'Activity' in the master bar.

@roccotripaldi
Copy link
Member

screen shot 2018-09-04 at 2 07 28 pm

@enejb
Copy link
Member Author

enejb commented Sep 4, 2018

It could be that you don't have the latest css files. I think I will need to bump some sort of version

@enejb
Copy link
Member Author

enejb commented Sep 4, 2018

The version already gets bumped eveytime there is a new version of Jetpack.

So changing the version number of Jetpack should do the trick. Can you try/test that?

@lezama
Copy link
Contributor

lezama commented Sep 4, 2018

worked well for me

@enejb enejb dismissed roccotripaldi’s stale review September 4, 2018 19:20

A new version will bust the css files cache

@enejb enejb merged commit a455d15 into master Sep 4, 2018
@enejb enejb deleted the update/masterbar-with-activity-log-link branch September 4, 2018 19:20
@jeherve jeherve added the [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations label Sep 5, 2018
jeherve added a commit that referenced this pull request Sep 14, 2018
jeherve added a commit that referenced this pull request Sep 24, 2018
jeherve added a commit that referenced this pull request Sep 25, 2018
* Readme: add boilerplate for next release, 6.6

* Add 6.5 to the changelog.txt file

* Set boilerplate testing list for 6.6

* Readme: update stable tag to 6.5

* Add bullets to 6.5 changelog items

* Readme: add link to previous changelogs

This will help folks who want to know more about past releases,
while keeping the readme.txt short so as to not overwhelm translators and site owners only looking for information about the last release.

* Changelog: add information at the top of the changelog file.

* Changelog: add #10054

* Changelog: add #10078

* Changelog: add #10079

* Changelog: add #10064

* Changelog: add #10094

* Changelog: add #10096

* Testing list: add more information based on #10087

* Changelog: add #9847

* Changelog: add #10084

* Changelog: add #9918

* Changelog: add #7614

* Changelog: add #10116

* Changelog: add #10108

* Changelog: add #10041

* Changelog: add #10121

* Changelog: add #10134

* Changelog: add #10130

* Changelog: add #10109

* changelog: add #10137

* changelog: add #9952

* changelog: add #10120

* changelog: add #10162

* Changelog: add #10163

* Changelog: add #10092

* changelog: add #10156

* Changelog: add #10154

* changelog: add #10122

* Changelog: add #10101

* changelog: add #10105

* changelog: add #10190

* Changelog: add #10196

* changelog: add #10152

* Changelog: add #10153

* Testing list: add more details to Site Verification testing steps.

@see #10143 (comment)

* changelog: add #10194

* Changelog: add #10193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Activity Log [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants