impl ZcashIndexer for StateService

zaino-fetch/src/jsonrpc/connector.rs

@@ -57,6 +57,17 @@ pub struct RpcError {
 }
 
 impl RpcError {
+    /// Creates a new `RpcError` from zebra's `LegacyCode` enum
+    pub fn new_from_legacycode(
+        code: zebra_rpc::server::error::LegacyCode,
+        message: impl Into<String>,
+    ) -> Self {
+        RpcError {
+            code: code as i64,
+            message: message.into(),
+            data: None,
+        }
+    }
     /// Creates a new `RpcError` from jsonrpsee-types `ErrorObject`.
     pub fn new_from_errorobject(
         error_obj: jsonrpsee_types::ErrorObject<'_>,

zaino-state/src/fetch.rs

@@ -1825,7 +1825,7 @@ mod tests {
             .unwrap();
 
         dbg!(recipient_balance.clone());
-        dbg!(fetch_service_balance.clone());
+        dbg!(fetch_service_balance);
 
         assert_eq!(recipient_balance.transparent_balance.unwrap(), 250_000,);
         assert_eq!(
@@ -1931,7 +1931,9 @@ mod tests {
 
         dbg!(&fetch_service_mempool);
         dbg!(&json_service_mempool);
-        assert_eq!(json_service_mempool.sort(), fetch_service_mempool.sort());
+        json_service_mempool.sort();
+        fetch_service_mempool.sort();
+        assert_eq!(json_service_mempool, fetch_service_mempool);
 
         test_manager.close().await;
     }
@@ -2549,13 +2551,13 @@ mod tests {
         let mut sorted_fetch_mempool_tx = fetch_mempool_tx.clone();
         sorted_fetch_mempool_tx.sort_by_key(|tx| tx.hash.clone());
 
-        let mut tx1_bytes = tx_1.first().as_ref().clone();
+        let mut tx1_bytes = *tx_1.first().as_ref();
         tx1_bytes.reverse();
-        let mut tx2_bytes = tx_2.first().as_ref().clone();
+        let mut tx2_bytes = *tx_2.first().as_ref();
         tx2_bytes.reverse();
 
-        let mut sorted_txids = vec![tx1_bytes, tx2_bytes];
-        sorted_txids.sort_by_key(|hash| hash.clone());
+        let mut sorted_txids = [tx1_bytes, tx2_bytes];
+        sorted_txids.sort_by_key(|hash| *hash);
 
         assert_eq!(sorted_fetch_mempool_tx[0].hash, sorted_txids[0]);
         assert_eq!(sorted_fetch_mempool_tx[1].hash, sorted_txids[1]);

zaino-state/src/local_cache.rs

@@ -55,10 +55,10 @@ impl BlockCache {
 
     /// Returns a [`BlockCacheSubscriber`].
     pub fn subscriber(&self) -> BlockCacheSubscriber {
-        let finalised_state_subscriber = match &self.finalised_state {
-            Some(finalised_state) => Some(finalised_state.subscriber()),
-            None => None,
-        };
+        let finalised_state_subscriber = self
+            .finalised_state
+            .as_ref()
+            .map(FinalisedState::subscriber);
         BlockCacheSubscriber {
             fetcher: self.fetcher.clone(),
             non_finalised_state: self.non_finalised_state.subscriber(),