Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl ZcashIndexer for StateService #178

Merged
merged 14 commits into from
Feb 13, 2025
Merged

Conversation

AloeareV
Copy link
Contributor

@AloeareV AloeareV commented Jan 31, 2025

This is in need of testing, which I plan to start on today.
Completes #111 and #113

@idky137 idky137 added the ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2 label Feb 4, 2025
Copy link
Contributor

@idky137 idky137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

The only things i can see without more testing is that the impl StateService on line 770 is now mostly defunct. I think it is only the get_block_header method that is now used.

Maybe this should be grouped in an impl StateService with the get_compact_block and to_tx methods from the impl block starting on line 1222.

The get_block_range could be left in its own impl that will be converted to the LightWalletIndexer trait in Milestone 3?

The other thing is that mempool data is also available by adding a zaino-state::Mempool to StateService. This would require the StateService to also implement a StateServiceSubscriber in the same way FetchService does so it may be best to wait until we implement the LightWalletIndexer trait in Milestone 3 for this work.

idky137
idky137 previously approved these changes Feb 12, 2025
@AloeareV AloeareV merged commit dc3cbc1 into zingolabs:dev Feb 13, 2025
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZGM2 Issues that need to be resolved for the completion of the Zaino dev grant milestone 2
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants