Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Ipython shell into the tutorial notebook #1229

Closed
wants to merge 17 commits into from

Conversation

GbotemiB
Copy link
Contributor

fixes #514 #1163

@joshmoore @MSanKeys963 @jakirkham

In this PR, i have converted most of the columns into codes with output.

Extension to support ipython in the docs have been added to conf.py.

There are still some lines that generate error.

Suggestions are welcome on how to handle the errors.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1229 (afd5ca4) into main (8e6fe11) will not change coverage.
Report is 168 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1229   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          35       35           
  Lines       14127    14123    -4     
=======================================
- Hits        14126    14122    -4     
  Misses          1        1           

see 3 files with indirect coverage changes

@joshmoore
Copy link
Member

ModuleNotFoundError: No module named 'IPython'

seems to be the most pressing issue. I assume it is needed here:

https://github.com/zarr-developers/zarr-python/blob/main/requirements_rtfd.txt

@GbotemiB
Copy link
Contributor Author

Thanks for the heads up @joshmoore. I have been trying to figure out where the issue is.

@jhamman
Copy link
Member

jhamman commented Dec 7, 2023

This has unfortunately gone stale. Will it be revived or should we close this?

@jhamman jhamman added stale documentation Improvements to the documentation labels Dec 7, 2023
@jhamman jhamman closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements to the documentation stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving the tutorial to a Jupyter notebook
3 participants