-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating tutorial.ipynb into readthedocs #1163
Conversation
Co-authored-by: Saransh Chopra <saransh0701@gmail.com> Co-authored-by: Saransh Chopra <saransh0701@gmail.com> Co-authored-by: jakirkham <jakirkham@gmail.com>
Thanks, @GbotemiB. I've triggered the build here, but not that in the rendered output at https://zarr--1163.org.readthedocs.build/en/1163/tutorial_nb.html some of the RST markup is not being properly rendered (since notebooks use markdown): |
this has been fixed in the recent commit |
@GbotemiB, does the notebook still run to completion on a fresh checkout if all of the data files that you added are not present? If so, can I suggest removing them from this PR? |
If the data files are not present, it won't affect the notebook. The notebook is set to not rerun so as to not affect the output. |
there are two ways I could co about the output of the notebook. I could run the notebook locally and set it to not rerun. This way the output will be saved. |
Understood. Thanks for the caution!
On readthedocs, then, right? Knowing the limited number of processes we have there, that wouldn't be great. Two other options that come to mind are: caching the outputs in a GHA or reducing the size of the rechunking section. Thoughts (from anyone) welcome. |
Thanks for working through this Emmanuel! 🙏 Some other things we might want to look at (in addition to nbsphinx) mentioned in issue ( #514 ) are...: No strong feelings about any of these options (including nbsphinx). Though it may be helpful to have a way to start with Another thing we might consider (especially as we have a few more people trying to get started with Zarr) is some sort of Binder integration, which would allow users to spin up the tutorial in the cloud and play around with it (without having to figure out how to install locally; at least not initially). |
Hi @jakirkham, I went through the other things you mentioned. Here is my thought
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 36 36
Lines 14141 14142 +1
=======================================
+ Hits 14134 14135 +1
Misses 7 7 |
Hi @joshmoore @jakirkham I would like to work on creating more tutorials that can be implemented on Binder. I would really appreciate pointers on how to get started. Thank you. |
@zeelyha: that would be great! Have you seen the tutorials repo? https://github.com/zarr-developers/tutorials Starting from the notebook here or any of those over there, I'd make a copy and see if you can start modifying the example to do something slightly different. That could be something from https://zarr.readthedocs.io/en/stable/tutorial.html or something you find online (e.g. from twitter) You can find datasets online either at https://pangeo-forge.org/catalog or https://idr.github.io/ome-ngff-samples/ |
@joshmoore Yes, I have gone through the repo and I just finished watching the interactive tutorial video. I'd be waiting for a copy of the notebook so I can start modifying the examples. |
I'm not sure what you mean. Let's perhaps move this conversation back to https://gitter.im/zarr-developers/outreachy-contributors-dec-2022 to not steal @GbotemiB's PR. |
Integrating a jupyter notebook into the readthedocs to serve as the tutorial file, will require removing the so far, i have tested it, its actually preferable to using a jupyter notebook and the file structure will still be maintained. We could decide to go for any of the two. |
I'm going to close this as stale. Folks should feel free to reopen if there is interest in continuing this work. |
I was able to get started with integrating the tutorial.ipynb file into the readthedocs using nbsphinx. Though I still have issues with the tutorial.ipynb file. It still needs some re-editing.
Also, i am not able to resolve importing numpydoc when building the fiiles for the tutorial page.