Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer card tweaks #156

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Timer card tweaks #156

merged 1 commit into from
Sep 10, 2023

Conversation

M00NJ
Copy link
Member

@M00NJ M00NJ commented Sep 10, 2023

Some small tweaks to the timer card. The FAB should only be used for the primary action and only at the bottom of the screen, so I replaced it with a FilledIconButton which looks great here. I also increased the timer font size and removed the milliseconds. They only make sense in the stopwatch tab IMO and make the UI more busy. Also did some minor padding tweaks.

Before:
signal-2023-09-10-17-08-59-535

After:
signal-2023-09-10-17-09-12-782

Some more ideas to improve the timer card would be to

  1. replace the delete button by swipe to dismiss
  2. hide the label and sound icons by animated visibility like in the alarm card, since I think they're rarely used and the UI could be more minimal that way

I'm interested in your opinion on that.

@SuhasDissa
Copy link
Member

Looks good to me 🚀

@SuhasDissa
Copy link
Member

SuhasDissa commented Sep 10, 2023

Removing the hundreds is a good idea IMO. We don't need that much precision in a timer.

I have some things to add to your idea list.

  • Add hours counter instead of showing hours as minutes.
  • Show when the timer will finish.
  • Expand timer to fit full screen by clicking it.

@M00NJ
Copy link
Member Author

M00NJ commented Sep 10, 2023

I have some things to add to your idea list.

  1. Agreed
  2. Do you mean the exact time of the day, when the timer ends?
  3. Interesting idea. Though a full screen alarm with a swipe gesture to dismiss when a timer/alarm ends would be more useful I think. Would require "display over apps" permission.

@SuhasDissa
Copy link
Member

  1. Yes, for example if I set a timer for two hours at 8.30 am, then it should show the end time as 10.30 am.

  2. Clicking the timer should expand it and show it with a bigger font and a circular progress indicator.
    This will be useful when using timers for exams or assignments, because its less distracting and easy to read.

This can be done by using a full screen dialog.

@Bnyro
Copy link
Member

Bnyro commented Sep 10, 2023

Moonj:

  1. Swipe to dismiss sounds like a good idea here
  2. I don't think that's a good idea because it'd make the UI more complicated. If we add 1., there's enough space to keep the edit and sound button

Suhas:

  1. Agree on showing hours as hours instead of large amount of minutes
  2. That sounds like a decent idea, but how are we going to place it? Maybe in the full screen dialog you mentioned for 3.?
  3. Good idea! We could use that to display the time when it finishes and the selected alarm sound too.

@M00NJ
Copy link
Member Author

M00NJ commented Sep 10, 2023

I'll merge this now so I can do the release, since I'm busy tomorrow.

@M00NJ M00NJ merged commit 4b16d86 into you-apps:main Sep 10, 2023
@M00NJ M00NJ deleted the timer-card-tweaks branch October 11, 2023 17:01
@M00NJ M00NJ mentioned this pull request Dec 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants