Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move argus client code to ancla #815

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Jan 7, 2025

  • currently, servers that use ancla will also have a indirect dependency on argus, because argus contains client code that ancla needs
  • the client code in argus is only used by ancla and not argus itself
  • servers having an indirect dependency on argus will and have complicated upgrades and maintenance
  • the code will be moved to refactor: move argus client code to ancla ancla#271

@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Jan 7, 2025
@denopink denopink self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.90%. Comparing base (25151a7) to head (d054bce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   48.04%   42.90%   -5.15%     
==========================================
  Files          28       23       -5     
  Lines        1717     1473     -244     
==========================================
- Hits          825      632     -193     
+ Misses        872      832      -40     
+ Partials       20        9      -11     
Flag Coverage Δ
unittests 42.90% <ø> (-5.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink merged commit c47d762 into main Jan 8, 2025
17 of 18 checks passed
@denopink denopink deleted the denopink/refactor/move-argus-client-code-to-ancla branch January 8, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants