Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move argus client code to ancla #271

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Jan 7, 2025

  • currently, servers that use ancla will also have a indirect dependency on argus, because argus contains client code that ancla needs
  • the client code in argus is only used by ancla and not argus itself
  • servers having an indirect dependency on argus will and have complicated upgrades and maintenance
  • this code was moved from refactor: move argus client code to ancla argus#815

@denopink denopink self-assigned this Jan 7, 2025
@denopink denopink added the enhancement improvement or small functionality added to an existing feature label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 79.09836% with 51 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (f32f0cc) to head (4d78051).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
chrysom/basicClient.go 85.71% 13 Missing and 7 partials ⚠️
chrysom/listenerClient.go 87.95% 6 Missing and 4 partials ⚠️
chrysom/metrics.go 0.00% 10 Missing ⚠️
chrysom/pushResult.go 0.00% 9 Missing ⚠️
chrysom/store.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   84.36%   82.58%   -1.79%     
==========================================
  Files          13       18       +5     
  Lines         646      890     +244     
==========================================
+ Hits          545      735     +190     
- Misses         88      130      +42     
- Partials       13       25      +12     
Flag Coverage Δ
unittests 82.58% <79.09%> (-1.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink force-pushed the denopink/refactor/move-argus-client-code-to-ancla branch from 7f78586 to 4d78051 Compare January 7, 2025 21:17
denopink added a commit that referenced this pull request Jan 8, 2025
- once #271 is merged, `chrysom/acquire` will replace `bascule`
- `chrysom/acquire` will allow the user to provide there own auth implementation instead of ancla relying on `bascule`
- `chrysom/acquire` will be integrated once #271 is merged
@denopink denopink merged commit 35dae74 into main Jan 8, 2025
15 of 17 checks passed
@denopink denopink deleted the denopink/refactor/move-argus-client-code-to-ancla branch January 8, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants