Add data store parameters and data ID to the assets in the STAC published by xcube server #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstntokas
force-pushed
the
konstntokas-1020-xcube_server_add_store_parameters_to_stac_asset
branch
from
b0eed73 to
94891be
Compare
konstntokas
force-pushed
the
konstntokas-1020-xcube_server_add_store_parameters_to_stac_asset
branch
from
55a51d4 to
12dba1d
Compare
konstntokas
force-pushed
the
konstntokas-1020-xcube_server_add_store_parameters_to_stac_asset
branch
from
12dba1d to
c806c6d
Compare
forman
requested changes
Jul 10, 2024
CHANGES.md
Outdated
| @@ -26,6 +26,11 @@ | |||
| * The `xcube.core.store.DataDescriptor` class now supports specifying time ranges | |||
| using both `datetime.date` and `datetime.datetime` objects. Previously, | |||
| only `datetime.date` objects were supported. | |||
| * The xcube server STAC publication has been adjusted so that the data store | |||
There was a problem hiding this comment.
Suggested change
| * The xcube server STAC publication has been adjusted so that the data store | |
| * The xcube server STAC API has been adjusted so that the data store |
CHANGES.md
Outdated
| @@ -26,6 +26,11 @@ | |||
| * The `xcube.core.store.DataDescriptor` class now supports specifying time ranges | |||
| using both `datetime.date` and `datetime.datetime` objects. Previously, | |||
| only `datetime.date` objects were supported. | |||
| * The xcube server STAC publication has been adjusted so that the data store | |||
| parameters and data ID, which are needed to open the data, | |||
There was a problem hiding this comment.
Suggested change
| parameters and data ID, which are needed to open the data, | |
| parameters and data ID, which are needed to open the data referred to by a STAC item, |
CHANGES.md
Outdated
| @@ -26,6 +26,11 @@ | |||
| * The `xcube.core.store.DataDescriptor` class now supports specifying time ranges | |||
| using both `datetime.date` and `datetime.datetime` objects. Previously, | |||
| only `datetime.date` objects were supported. | |||
| * The xcube server STAC publication has been adjusted so that the data store | |||
| parameters and data ID, which are needed to open the data, | |||
| are now included with the asset; furthermore, a second assert called | |||
There was a problem hiding this comment.
Suggested change
| are now included with the asset; furthermore, a second assert called | |
| are now included with the item's `analytic` asset. | |
| Furthermore, a second assert called |
| @@ -7,6 +7,19 @@ | |||
| ], | |||
| "type": "application/zarr", | |||
| "href": "http://localhost:8080/s3/datasets/demo.zarr", | |||
| "xcube:store_kwargs": { | |||
There was a problem hiding this comment.
Suggested change
| "xcube:store_kwargs": { | |
| "xcube:data_store_params": { |
to align it with keyword argument data_store_params of the data store API function new_data_store().
| @@ -7,6 +7,19 @@ | |||
| ], | |||
| "type": "application/zarr", | |||
| "href": "http://localhost:8080/s3/datasets/demo.zarr", | |||
| "xcube:store_kwargs": { | |||
| "data_store_id": "s3", | |||
There was a problem hiding this comment.
Use separate asset xcube:data_store_id to align it with the positional argument data_store_id of the data store API function new_data_store().
| } | ||
| } | ||
| }, | ||
| "xcube:open_kwargs": { |
There was a problem hiding this comment.
Suggested change
| "xcube:open_kwargs": { | |
| "xcube:open_data_params": { |
to align it with data store API method DataStore.open_data() (-> open_data) that takes all the given parameters (-> params). And align it API method DataStore.get_open_data_params_schema() .
| } | ||
| } | ||
| }, | ||
| "xcube:open_kwargs": { |
| ], | ||
| "type": "application/zarr", | ||
| "href": "http://localhost:8080/s3/pyramids/demo.levels", | ||
| "xcube:store_kwargs": { |
xcube/webapi/ows/stac/controllers.py
Outdated
|
|
||
| return { | ||
| "analytic": { | ||
| "title": f"{dataset_id} data access", | ||
| "roles": ["data"], | ||
| "type": "application/zarr", | ||
| "href": f"{default_storage_url}/{dataset_id}.zarr", | ||
| "href": f"{base_url}/s3/datasets/{dataset_id}.zarr", | ||
| "xcube:store_kwargs": { |
There was a problem hiding this comment.
See my comments on test/webapi/ows/stac/demo-collection.json above.
| "xcube:analytic": { | ||
| v["name"]: { | ||
| "title": f"{v['name']} data access", | ||
| "roles": ["data"], | ||
| "type": "application/zarr", | ||
| "href": f"{default_storage_url}/" f"{dataset_id}.zarr/{v['name']}", | ||
| "href": f"{base_url}/s3/datasets/{dataset_id}.zarr/{v['name']}", |
There was a problem hiding this comment.
See my comments on test/webapi/ows/stac/demo-collection.json above.
konstntokas
deleted the
konstntokas-1020-xcube_server_add_store_parameters_to_stac_asset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1020
Checklist:
Add docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*CHANGES.md