This repository has been archived by the owner on May 1, 2024. It is now read-only.
RelativeSource Binding Bug Fixes (Gh8450) #8541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legistek
changed the title
StephaneDelcroix
approved these changes
Nov 18, 2019
StephaneDelcroix
added
the
retarget-branch-required
(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes; (2) fix incorrect interpretation of AncestorLevel; (3) much more robust unit tests for RelativeSource ancestor-type binding (#4)
legistek
force-pushed
the
gh8450-relsourcebugs-on-430
branch
from
3e9f344 to
3e0cffb
Compare
|
Sure thing - done. |
samhouts
removed
the
retarget-branch-required
samhouts
approved these changes
Nov 18, 2019
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
samhouts
added
the
approved
Merged
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
See #8450 which describes two issues left over from the original inclusion of the feature in #4375
Issues Resolved
Fixes #8450
API Changes
None
Platforms Affected
All
Behavioral/Visual Changes
FindAncestorBindingContextmode will function correctly withBindingContextchanges and reparenting.AncestorLevelwill function in accordance with the documentation.Testing Procedure
Unit tests for this feature have been revised.
PR Checklist